Skip to content

fixes issue when using a remote path: files are not skipped anymore #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arthuraulin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes issue when using a remote path: files are not skipped anymore #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,12 @@ Number of retries when network error occuers. Default case, after 3 reties valid
Type: `String` <br/>
Default value: ``

#### options.tempPath
Type: `String` <br/>
Default value: ``

When a remote path is used, this defines where the temporary html files are saved before they are validated.

#### options.wrapfile
Type: `String` <br/>
Default value: ``
Expand Down
9 changes: 5 additions & 4 deletions tasks/html_validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ module.exports = function (grunt) {
var options = this.options({
path: 'validation-status.json',
reportpath: 'validation-report.json',
tempPath: '',
reset: false,
proxy: null,
stoponerror: false,
Expand Down Expand Up @@ -254,7 +255,7 @@ module.exports = function (grunt) {
return;
}

rval(dummyFile[counter], function () {
rval(dummyFile[counter], options.remotePath, options.tempPath, function () {
validate(files);
});

Expand Down Expand Up @@ -297,7 +298,7 @@ module.exports = function (grunt) {
* Note on Remote validation.
* W3Cjs supports remote file validation but due to some reasons it is not working as expected.
* Local file validation is working perfectly. To overcome this remote page is fetch using 'request'
* npm module and write page content in '_tempvlidation.html' file and validates as local file.
* npm module and write page content in a local html file and validates it.
*/

if (!options.remotePath && options.remoteFiles) {
Expand Down Expand Up @@ -325,10 +326,10 @@ module.exports = function (grunt) {
files = [];

for (var i = 0; i < dummyFile.length; i++) {
files.push('_tempvlidation.html');
files.push(options.tempPath + '/' + '_' + dummyFile[i].replace(options.remotePath, '') + '.html');
}

rval(dummyFile[counter], function () {
rval(dummyFile[counter], options.remotePath, options.tempPath, function () {
validate(files);
});

Expand Down
4 changes: 2 additions & 2 deletions tasks/lib/remoteval.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

'use strict';

module.exports = function remoteval (file, cb) {
module.exports = function remoteval (file, remotePath, tempPath, cb) {

var request = require('request');
var grunt = require('grunt');
Expand All @@ -21,7 +21,7 @@ module.exports = function remoteval (file, cb) {
}

if (!error && response.statusCode === 200) {
grunt.file.write('_tempvlidation.html', body);
grunt.file.write(tempPath + '/' + '_' + file.replace(remotePath, '') + '.html', body);
return cb(true);
}
});
Expand Down