Relaxerror can be exact string match#77
Open
basteln3rk wants to merge 2 commits into
Open
Conversation
- either regular expression (previous functionality) - or match exactly the error string (new functionality) this helps getting around confusing double escaping required when trying to silence the error '& did not start a character reference. (& probably should have been escaped as &.)' with regexp only, it is required to put into relaxerrors '\\& did not start a character reference. \\(\\& probably should have been escaped as \\&.\\)'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this patch allows relaxerror to be not just regular expression (previous functionality), but alternatively to match exactly the error string (new functionality)
this helps getting around confusing double escaping required when trying to silence the error
& did not start a character reference. (& probably should have been escaped as &.)(see discussion: http://stackoverflow.com/questions/15970738/did-not-start-a-character-reference-probably-should-have-been-escaped-as)with regexp only, as before this PR, it is required to put into relaxerrors
\\& did not start a character reference. \\(\\& probably should have been escaped as \\&.\\), which is a bit ugly