Merge pull request #38 from filipbech/patch-1

marvinhagemeister · web-flow · commit 63e29030c0f9 · 2020-08-26T10:16:52.000+02:00
Change detachedCallback to disconnectedCallback
diff --git a/src/index.js b/src/index.js
@@ -11,7 +11,7 @@ export default function register(Component, tagName, propNames, options) {
 	PreactElement.prototype.constructor = PreactElement;
 	PreactElement.prototype.connectedCallback = connectedCallback;
 	PreactElement.prototype.attributeChangedCallback = attributeChangedCallback;
-	PreactElement.prototype.detachedCallback = detachedCallback;
+	PreactElement.prototype.disconnectedCallback = disconnectedCallback;
 	PreactElement.observedAttributes = propNames || Component.observedAttributes || Object.keys(Component.propTypes || {});
 
 	return customElements.define(
@@ -40,7 +40,7 @@ function attributeChangedCallback(name, oldValue, newValue) {
 	render(this._vdom, this._root);
 }
 
-function detachedCallback() {
+function disconnectedCallback() {
 	render(this._vdom = null, this._root);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ export default function register(Component, tagName, propNames, options) {`
`11`	`11`	`PreactElement.prototype.constructor = PreactElement;`
`12`	`12`	`PreactElement.prototype.connectedCallback = connectedCallback;`
`13`	`13`	`PreactElement.prototype.attributeChangedCallback = attributeChangedCallback;`
`14`		`- PreactElement.prototype.detachedCallback = detachedCallback;`
	`14`	`+ PreactElement.prototype.disconnectedCallback = disconnectedCallback;`
`15`	`15`	`PreactElement.observedAttributes = propNames \|\| Component.observedAttributes \|\| Object.keys(Component.propTypes \|\| {});`
`16`	`16`
`17`	`17`	`return customElements.define(`
`@@ -40,7 +40,7 @@ function attributeChangedCallback(name, oldValue, newValue) {`
`40`	`40`	`render(this._vdom, this._root);`
`41`	`41`	`}`
`42`	`42`
`43`		`-function detachedCallback() {`
	`43`	`+function disconnectedCallback() {`
`44`	`44`	`render(this._vdom = null, this._root);`
`45`	`45`	`}`
`46`	`46`