Cleanup IE11 mentions

Author: JoviDeCroock

README.md

@@ -13,7 +13,7 @@
 - Extensive React compatibility via a simple [preact/compat] alias
 - Everything you need: JSX, <abbr title="Virtual DOM">VDOM</abbr>, [DevTools], <abbr title="Hot Module Replacement">HMR</abbr>, <abbr title="Server-Side Rendering">SSR</abbr>.
 - Highly optimized diff algorithm and seamless hydration from Server Side Rendering
-- Supports all modern browsers and IE11
+- Supports all modern browsers
 - Transparent asynchronous rendering with a pluggable scheduler
 
 ### 💁 More information at the [Preact Website ➞](https://preactjs.com)

compat/test/browser/events.test.js

@@ -30,10 +30,6 @@ describe('preact/compat events', () => {
 
 	it('should patch events', () => {
 		let spy = sinon.spy(event => {
-			// Calling ev.preventDefault() outside of an event handler
-			// does nothing in IE11. So we move these asserts inside
-			// the event handler. We ensure that it's called once
-			// in another assertion
 			expect(event.isDefaultPrevented()).to.be.false;
 			event.preventDefault();
 			expect(event.isDefaultPrevented()).to.be.true;
@@ -89,16 +85,11 @@ describe('preact/compat events', () => {
 		expect(vnode.props).to.not.haveOwnProperty('oninputCapture');
 	});
 
-	it('should normalize onChange for range, except in IE11', () => {
-		// NOTE: we don't normalize `onchange` for range inputs in IE11.
-		const eventType = /Trident\//.test(navigator.userAgent)
-			? 'change'
-			: 'input';
-
+	it('should normalize onChange for range', () => {
 		render(<input type="range" onChange={() => null} />, scratch);
 		expect(proto.addEventListener).to.have.been.calledOnce;
 		expect(proto.addEventListener).to.have.been.calledWithExactly(
-			eventType,
+			'input',
 			sinon.match.func,
 			false
 		);

compat/test/browser/render.test.js

@@ -264,12 +264,7 @@ describe('compat render', () => {
 			scratch
 		);
 
-		let html = sortAttributes(scratch.innerHTML);
-		if (/Trident/.test(navigator.userAgent)) {
-			html = html.toLowerCase();
-		}
-
-		expect(html).to.equal(
+		expect(sortAttributes(scratch.innerHTML)).to.equal(
 			'<link as="image" href="preact.jpg" imagesrcset="preact_400px.jpg 400w" rel="preload">'
 		);
 	});

compat/test/browser/textarea.test.js

@@ -33,17 +33,10 @@ describe('Textarea', () => {
 		hydrate(<App />, scratch);
 		expect(scratch.firstElementChild.value).to.equal('foo');
 
-		// IE11 always displays the value as node.innerHTML
-		if (!/Trident/.test(window.navigator.userAgent)) {
-			expect(scratch.innerHTML).to.be.equal('<textarea></textarea>');
-		}
+		expect(scratch.innerHTML).to.be.equal('<textarea></textarea>');
 	});
 
 	it('should alias defaultValue to children', () => {
-		// TODO: IE11 doesn't update `node.value` when
-		// `node.defaultValue` is set.
-		if (/Trident/.test(navigator.userAgent)) return;
-
 		render(<textarea defaultValue="foo" />, scratch);
 
 		expect(scratch.firstElementChild.value).to.equal('foo');
@@ -67,21 +60,13 @@ describe('Textarea', () => {
 		// missing from HTML because innerHTML doesn't serialize form field values.
 		// See demo: https://jsfiddle.net/4had2Lu8
 		// Related renderToString PR: preactjs/preact-render-to-string#161
-		//
-		// This is not true for IE11. It displays the value in
-		// node.innerHTML regardless.
-		if (!/Trident/.test(window.navigator.userAgent)) {
-			expect(scratch.innerHTML).to.equal('<textarea></textarea>');
-		}
+		expect(scratch.innerHTML).to.equal('<textarea></textarea>');
 		expect(scratch.firstElementChild.value).to.equal('hello');
 
 		act(() => {
 			set('');
 		});
-		// Same as earlier: IE11 always displays the value as node.innerHTML
-		if (!/Trident/.test(window.navigator.userAgent)) {
-			expect(scratch.innerHTML).to.equal('<textarea></textarea>');
-		}
+		expect(scratch.innerHTML).to.equal('<textarea></textarea>');
 		expect(scratch.firstElementChild.value).to.equal('');
 	});
 });

test/browser/hydrate.test.js

@@ -225,10 +225,7 @@ describe('hydrate()', () => {
 		clearLog();
 		hydrate(vnode, scratch);
 
-		// IE11 doesn't support spying on Element.prototype
-		if (!/Trident/.test(navigator.userAgent)) {
-			expect(attributesSpy.get).to.not.have.been.called;
-		}
+		expect(attributesSpy.get).to.not.have.been.called;
 
 		expect(serializeHtml(scratch)).to.equal(
 			sortAttributes(
@@ -377,10 +374,7 @@ describe('hydrate()', () => {
 		);
 
 		hydrate(preactElement, scratch);
-		// IE11 doesn't support spies on built-in prototypes
-		if (!/Trident/.test(navigator.userAgent)) {
-			expect(attributesSpy.get).to.not.have.been.called;
-		}
+		expect(attributesSpy.get).to.not.have.been.called;
 		expect(scratch).to.have.property(
 			'innerHTML',
 			'<div><a foo="bar"></a></div>'

test/browser/render.test.js

@@ -24,8 +24,6 @@ function getAttributes(node) {
 	return attrs;
 }
 
-const isIE11 = /Trident\//.test(navigator.userAgent);
-
 describe('render()', () => {
 	let scratch, rerender;
 
@@ -84,13 +82,10 @@ describe('render()', () => {
 		expect(scratch.innerHTML).to.eql(`<img width="100%" height="100%">`);
 	});
 
-	// IE11 doesn't support these.
-	if (!/Trident/.test(window.navigator.userAgent)) {
-		it('should render px width and height on img correctly', () => {
-			render(<img width="100px" height="100px" />, scratch);
-			expect(scratch.innerHTML).to.eql(`<img width="100px" height="100px">`);
-		});
-	}
+	it('should render px width and height on img correctly', () => {
+		render(<img width="100px" height="100px" />, scratch);
+		expect(scratch.innerHTML).to.eql(`<img width="100px" height="100px">`);
+	});
 
 	it('should support the <template> tag', () => {
 		function App() {
@@ -126,10 +121,6 @@ describe('render()', () => {
 		expect(scratch.childNodes[0].nodeName).to.equal('SPAN');
 	});
 
-	it('should not throw error in IE11 with type date', () => {
-		expect(() => render(<input type="date" />, scratch)).to.not.throw();
-	});
-
 	it('should support custom tag names', () => {
 		render(<foo />, scratch);
 		expect(scratch.childNodes).to.have.length(1);
@@ -168,11 +159,8 @@ describe('render()', () => {
 		const button = div.childNodes[1];
 		const input = div.childNodes[2];
 
-		// IE11 doesn't support the form attribute
-		if (!isIE11) {
-			expect(button).to.have.property('form', form);
-			expect(input).to.have.property('form', form);
-		}
+		expect(button).to.have.property('form', form);
+		expect(input).to.have.property('form', form);
 	});
 
 	it('should allow VNode reuse', () => {
@@ -401,42 +389,38 @@ describe('render()', () => {
 		expect(scratch.firstChild.value).to.equal('0.5');
 	});
 
-	// IE or IE Edge will throw when attribute values don't conform to the
-	// spec. That's the correct behaviour, but bad for this test...
-	if (!/(Edge|MSIE|Trident)/.test(navigator.userAgent)) {
-		it('should not clear falsy DOM properties', () => {
-			function test(val) {
-				render(
-					<div>
-						<input value={val} />
-						<table border={val} />
-					</div>,
-					scratch
-				);
-			}
-
-			test('2');
-			test(false);
-			expect(scratch.innerHTML).to.equal(
-				'<div><input><table border="false"></table></div>',
-				'for false'
+	it('should not clear falsy DOM properties', () => {
+		function test(val) {
+			render(
+				<div>
+					<input value={val} />
+					<table border={val} />
+				</div>,
+				scratch
 			);
+		}
 
-			test('3');
-			test(null);
-			expect(scratch.innerHTML).to.equal(
-				'<div><input><table border=""></table></div>',
-				'for null'
-			);
+		test('2');
+		test(false);
+		expect(scratch.innerHTML).to.equal(
+			'<div><input><table border="false"></table></div>',
+			'for false'
+		);
 
-			test('4');
-			test(undefined);
-			expect(scratch.innerHTML).to.equal(
-				'<div><input><table border=""></table></div>',
-				'for undefined'
-			);
-		});
-	}
+		test('3');
+		test(null);
+		expect(scratch.innerHTML).to.equal(
+			'<div><input><table border=""></table></div>',
+			'for null'
+		);
+
+		test('4');
+		test(undefined);
+		expect(scratch.innerHTML).to.equal(
+			'<div><input><table border=""></table></div>',
+			'for undefined'
+		);
+	});
 
 	// Test for #3969
 	it('should clear rowspan and colspan', () => {
@@ -1316,11 +1300,7 @@ describe('render()', () => {
 			'<div id="wrapper"><div id="page1">Page 1</div></div>'
 		);
 
-		// IE11 doesn't allow modifying Element.prototype functions properly.
-		// Custom spies will never be called.
-		if (!isIE11) {
-			expect(attributesSpy.get).to.not.have.been.called;
-		}
+		expect(attributesSpy.get).to.not.have.been.called;
 
 		render(
 			<div id="wrapper">
@@ -1332,11 +1312,7 @@ describe('render()', () => {
 			'<div id="wrapper"><div id="page2">Page 2</div></div>'
 		);
 
-		// IE11 doesn't allow modifying Element.prototype functions properly.
-		// Custom spies will never be called.
-		if (!isIE11) {
-			expect(attributesSpy.get).to.not.have.been.called;
-		}
+		expect(attributesSpy.get).to.not.have.been.called;
 	});
 
 	// #2926
@@ -1370,7 +1346,7 @@ describe('render()', () => {
 
 	// #3060
 	it('should reset tabindex on undefined/null', () => {
-		const defaultValue = isIE11 ? 0 : -1;
+		const defaultValue = -1;
 
 		render(<div tabIndex={0} />, scratch);
 		expect(scratch.firstChild.tabIndex).to.equal(0);

test/polyfills.js

@@ -1,11 +1,5 @@
 import * as kl from 'kolorist';
 
-// Something that's loaded before this file polyfills Symbol object.
-// We need to verify that it works in IE without that.
-if (/Trident/.test(window.navigator.userAgent)) {
-	window.Symbol = undefined;
-}
-
 // Fix Function#name on browsers that do not support it (IE).
 // Taken from: https://stackoverflow.com/a/17056530/755391
 if (!function f() {}.name) {