Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to SWI Prolog 6 #6

Open
flowma opened this issue Dec 11, 2013 · 6 comments
Open

Port to SWI Prolog 6 #6

flowma opened this issue Dec 11, 2013 · 6 comments
Assignees

Comments

@flowma
Copy link
Member

flowma commented Dec 11, 2013

Apparently, PrechacThis does not run on the current version 6 of SWI-Prolog. That means no installation the desktop, no cross compiling.

@ghost ghost assigned jjochen Dec 11, 2013
@flowma
Copy link
Member Author

flowma commented Dec 11, 2013

Engine seams to work

swipl siteswap_engine.pl
?- siteswap(3, 9, 4, 1, 2, [A,B,C,D]).
A = p(8 rdiv 3, 2, 4),
B = p(4 rdiv 3, 1, 4),
C = D, D = p(4, 0, 4)

@imccoy
Copy link

imccoy commented Apr 11, 2014

It might be worth taking another slightly-closer look. I've just tracked down a bug in the android version where patterns weren't being rotated correctly. The siteswap/14 predicate was returning both 42p11p and 2p11p4 (for example). It was because is_biggest compares the result of compare/3 with the atoms 'lt' and 'gt', but compare/3 actually produces the atoms '<' and '>'. Changing the test "Order = lt" to "Order = <" (and similarly for gt) got all the rotations to work correctly (I hope).

@havarpan
Copy link

just got this codebase to work here with swi-prolog 9.2.1 on ubuntu... or maybe it works... at least it seems to work on first sight

@jjochen
Copy link
Member

jjochen commented Feb 25, 2024

Nice 🎉
Found one issue when pressing the back to results link on the details page.

@havarpan
Copy link

yeah i found it too... just commented out the link haha... but i'll cleanup a bit and publish the updated codebase next week... only one patch in there... the dcg_whitespace didn't work properly

@havarpan
Copy link

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants