-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten solver hierarchy for flow-over-heated-plate #136
Comments
We also have the nearest-projection OpenFOAM-OpenFOAM cases (fluid and solid). This should probably be a different case in a separate directory |
Should we open a separate issue for the nearest-projection case? |
Good point, somehow we don't have it on the list at the moment. It needs to be in a separate directory, as the |
We should definitely keep it. What I don't like about it having it as a separate case is the duplication of the case itself. I would also like to point out that the nearest-projection handling in OpenFOAM is very specific: we define separated meshes for reading and writing. So, it is rather unlikely that we will ever have a similar case added (unless we add meshes artificially). |
As part of the tutorials restructuring we want to flatten the second (solver) hierarchy. For the
flow-over-heated-plate
case this is non-trivial.We currently have: https://github.com/precice/tutorials/tree/restructure/flow-over-heated-plate
We want instead:
For the CalculiX case see: #104
The OpenFOAM solid case needs to be ported from the OpenFOAM adapter.
Challenge: one preCICE config needs to fit all. This means
dimensions="2"
everywhere and the same coupling data names.Furthermore, we should get similar physical results for all combinations.
For further conventions please copy from the
turek-hron-fsi3
structure: https://github.com/precice/tutorials/tree/restructure/turek-hron-fsi3The text was updated successfully, but these errors were encountered: