Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow over heated plate uses Aitken acceleration (inconsistent) #313

Open
MakisH opened this issue Dec 1, 2022 · 2 comments
Open

Flow over heated plate uses Aitken acceleration (inconsistent) #313

MakisH opened this issue Dec 1, 2022 · 2 comments

Comments

@MakisH
Copy link
Member

MakisH commented Dec 1, 2022

See https://github.com/precice/tutorials/blob/0482e5b4d3e1604dd031d2b113a2aaa63733c9a8/flow-over-heated-plate/precice-config.xml

In contrast, the -nearest-projection variant uses IQN (which we should be showcasing): https://github.com/precice/tutorials/blob/0482e5b4d3e1604dd031d2b113a2aaa63733c9a8/flow-over-heated-plate-nearest-projection/precice-config.xml

I don't know why we have this difference (I would need to do some digging into relics), but using the same acceleration config as the -nearest-projection variant seems to be working.

@davidscn
Copy link
Member

davidscn commented Dec 5, 2022

IIRC the Aitken acceleration was way faster than the IQN acceleration, as the solver iterations are very cheap. I don't get why we apply everywhere IQN acceleration. In my opinion, the tutorials should cover all available configurations as good as possible.

@MakisH
Copy link
Member Author

MakisH commented Dec 5, 2022

We don't have to use IQN everywhere. In fact, some variety would also be useful for the system tests.

However, we should document the motivation for anything that looks inconsistent. We could even see this as a problem with the flow-over-heat-plate-* cases that use IQN (and change those to Aitken).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants