Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in structure of tutorials #461

Closed
8 tasks done
MakisH opened this issue Feb 7, 2024 · 5 comments
Closed
8 tasks done

Inconsistencies in structure of tutorials #461

MakisH opened this issue Feb 7, 2024 · 5 comments
Assignees
Milestone

Comments

@MakisH
Copy link
Member

MakisH commented Feb 7, 2024

Follow-up of #228. The structure is documented in the website and clarified in precice/precice.github.io#331.

The following tutorials need updates:

I would still consider the aste-turbine to be a very special case that is not meant to be extended or repeated in other tutorials.

Please comment regarding which cases you would like to port. No need to port every tutorial at once, but let's try to have a consistent structure until the next release of the tutorials.

@BenjaminRodenberg
Copy link
Member

I don't want to prioritize this before my thesis is submitted or at least close to submission. I think this is also something that could be easily done by a research assistant and not urgent.

@MakisH
Copy link
Member Author

MakisH commented Feb 7, 2024

You mean that you don't want to work on it now, or that you don't want that the structure changes now?

@BenjaminRodenberg
Copy link
Member

I'm fine with the structural changes and we can also implement them rather sooner than later, but I don't have time to do it myself now.

If I stumble across a point where I can briefly do it anyway, I will do it occasionally (e.g. 459ab90).

@MakisH
Copy link
Member Author

MakisH commented Feb 12, 2024

Thank you, I can also take over work packages on this.

@uekerman
Copy link
Member

Please don't update the oscillator before merging #466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants