Skip to content

fix: skip overdepending check for packages without binaries #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix: skip overdepending check for packages without binaries #1975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/post_process/checks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,12 @@ pub fn perform_linking_checks(
tracing::info!("{linked_package}");
});

// If there are no binaries, skip the overdepending check.
// Packages without binaries can't link against libraries.
if package_files.is_empty() {
return Ok(());
}

// If there are any unused run dependencies then it is "overdepending".
for run_dependency in resolved_run_dependencies.iter() {
if !package_files
Expand Down