From 0a13cd7a9dde341c6e38dd4ccce32e09bc35c39a Mon Sep 17 00:00:00 2001 From: Zac Blanco Date: Wed, 29 Jan 2025 16:34:22 -0800 Subject: [PATCH] Remove parentheses from release notes PR link (#40) --- .../release/tasks/GenerateReleaseNotesTask.java | 2 +- .../release-0.231_expected.rst | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java b/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java index 05e78bb..e1cb13b 100644 --- a/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java +++ b/presto-release-tools/src/main/java/com/facebook/presto/release/tasks/GenerateReleaseNotesTask.java @@ -297,7 +297,7 @@ private String generateReleaseNotes( List items = new ArrayList<>(releaseNotesByCategory.get(category)); sort(items, new ReleaseNoteItemComparator()); for (ReleaseNoteItem item : items) { - document.append("\n").append(item.getFormatted("*", 0)).append(format(" (`#%1$d `_)", item.pullRequest.getId())); + document.append("\n").append(item.getFormatted("*", 0)).append(format(" `#%1$d `_", item.pullRequest.getId())); } document.append("\n\n"); } diff --git a/presto-release-tools/src/test/resources/release-notes-test/release-0.231_expected.rst b/presto-release-tools/src/test/resources/release-notes-test/release-0.231_expected.rst index 8483741..dad3c31 100644 --- a/presto-release-tools/src/test/resources/release-notes-test/release-0.231_expected.rst +++ b/presto-release-tools/src/test/resources/release-notes-test/release-0.231_expected.rst @@ -10,17 +10,17 @@ Release 0.231 SPI Changes ___________ -* Change ``ConnectorMetadata#commitPartition`` into async operation, and rename it to ``ConnectorMetadata#commitPartitionAsync``. (`#2 `_) +* Change ``ConnectorMetadata#commitPartition`` into async operation, and rename it to ``ConnectorMetadata#commitPartitionAsync``. `#2 `_ Raptor Changes ______________ -* Fix an issue where DATE_TRUNC may produce incorrect results at certain timestamp in America/Sao_Paulo. (`#1 `_) -* Improve correctness check for RowType columns. Add specific validation checks for the individual fields when validating a row column. (`#2 `_) -* Add table_supports_delta_delete property in Raptor to allow deletion happening in background. DELETE queries in Raptor can now delete data logically but relying on compactors to delete physical data. (`#2 `_) -* Replace the ``SchemaTableName`` parameter in ``ConnectorMetadata#createView`` with a ``ConnectorTableMetadata``. (`#1 `_) -* Rename error code from ``RAPTOR_LOCAL_FILE_SYSTEM_ERROR`` to ``RAPTOR_FILE_SYSTEM_ERROR``. (`#1 `_) -* Remove unused FilterVoidLambda interface in ArrayFilterFunction. (`#2 `_) -* Change ``storage.data-directory` from path to URI. For existing deployment on local flash, a scheme header "file://" should be added to the original config value. (`#1 `_) +* Fix an issue where DATE_TRUNC may produce incorrect results at certain timestamp in America/Sao_Paulo. `#1 `_ +* Improve correctness check for RowType columns. Add specific validation checks for the individual fields when validating a row column. `#2 `_ +* Add table_supports_delta_delete property in Raptor to allow deletion happening in background. DELETE queries in Raptor can now delete data logically but relying on compactors to delete physical data. `#2 `_ +* Replace the ``SchemaTableName`` parameter in ``ConnectorMetadata#createView`` with a ``ConnectorTableMetadata``. `#1 `_ +* Rename error code from ``RAPTOR_LOCAL_FILE_SYSTEM_ERROR`` to ``RAPTOR_FILE_SYSTEM_ERROR``. `#1 `_ +* Remove unused FilterVoidLambda interface in ArrayFilterFunction. `#2 `_ +* Change ``storage.data-directory` from path to URI. For existing deployment on local flash, a scheme header "file://" should be added to the original config value. `#1 `_ **Credits** ===========