Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong DynamicDialog import on stackblitz examples #17362

Closed
4 tasks
daniela-bonvini opened this issue Jan 12, 2025 · 0 comments
Closed
4 tasks

Wrong DynamicDialog import on stackblitz examples #17362

daniela-bonvini opened this issue Jan 12, 2025 · 0 comments
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
19.0.6

Comments

@daniela-bonvini
Copy link
Contributor

Describe the bug

In version 19 of the library, all of the examples on Stackblitz are broken because the import.ts file wrongly imports DynamicDialog instead of DynamicDialogModule

Pull Request Link

#17361

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/y3qjkuju?file=src%2Fapp%2Fimports.ts

Environment

Windows

Angular version

19.0.6

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to a component page 2. open a Stackblitz example

Expected behavior

Stackblitz examples should implement the right module and work
@daniela-bonvini daniela-bonvini added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 12, 2025
@daniela-bonvini daniela-bonvini mentioned this issue Jan 12, 2025
Merged
@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2025
@mertsincan mertsincan added this to the 19.0.6 milestone Jan 15, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 15, 2025
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 15, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
PrimeNG
Status: Done
Milestone
19.0.6
Development

No branches or pull requests
2 participants
@mertsincan @daniela-bonvini