Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectButton: Material, Lara & Nora Theme - When disabled selected option is not visible #17374

Open
1 of 4 tasks
can-oezkan opened this issue Jan 13, 2025 · 0 comments
Open
1 of 4 tasks
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Milestone

Comments

@can-oezkan
Copy link
Contributor

can-oezkan commented Jan 13, 2025

Describe the bug

When the SelectButton is disabled it is impossible to tell which the current selection is:
image

I have provided a stackblitz example but the bug is also reproducible on the showcase site by switching the theme: https://primeng.org/selectbutton#disabled

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

No response

Reproducer

https://stackblitz.com/edit/github-pdvg2klr?file=src%2Fapp%2Fapp.component.html

Environment

stackblitz

Angular version

v19

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Add selection to SelectButton
  2. disable SelectButton component
  3. selection is not highlighted which makes it impossible to tell the current selection

Expected behavior

When the SelectButton is disabled the current selection should still be visible

@can-oezkan can-oezkan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 13, 2025
@can-oezkan can-oezkan changed the title SelectButton: Material, Lara & Nora - When disabled selected option is not visible SelectButton: Material, Lara & Nora Theme - When disabled selected option is not visible Jan 15, 2025
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team Component: Theme Issue or pull request is related to Theme and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2025
@mertsincan mertsincan added this to the 19.1.0 milestone Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Jan 16, 2025
@mertsincan mertsincan moved this from Review to Theme in PrimeNG Jan 16, 2025
@cagataycivici cagataycivici modified the milestones: 19.1.0, 19.0.6 Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Theme Issue or pull request is related to Theme Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
Status: Theme
Development

No branches or pull requests

3 participants