Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select component with filter: "No results found" entry should not be enabled or clickable #17382

Open
1 of 4 tasks
l3d00m opened this issue Jan 13, 2025 · 0 comments
Open
1 of 4 tasks
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@l3d00m
Copy link

l3d00m commented Jan 13, 2025

Describe the bug

When having a filter on the Select component and no results are found, the "No results found" option is enabled and clickable, which should not be the case since it does not have any action and might confuse screen readers. (I noticed in E2E playwright tests).

Pull Request Link

No response

Reason for not contributing a PR

  • Lack of time
  • Unsure how to implement the fix/feature
  • Difficulty understanding the codebase
  • Other

Other Reason

not sure if this is actually considered a bug

Reproducer

https://primeng.org/select#filter

Environment

Can be seen on PrimeNG documentation website (Filter section). See link above.

Angular version

on primeNG docs site

PrimeNG version

v19

Node version

No response

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primeng.org/select#filter (Filter section)
  2. Enter random characters until "No results found" is displayed
  3. Notice that the option item with this text is enabled:
    image

Expected behavior

The item should not be enabled and should not clickable or selectable with screen readers. Because it is an information text only with no click action.

@l3d00m l3d00m added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant