-
Notifications
You must be signed in to change notification settings - Fork 142
Add missing zh(Hans) translation pages #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @lirenjie95 , thank you so much for your attention to this. Yes, please feel free to use this issue to track all PRs across both repos and go ahead to work on the points you made. Feel free to split them up in multiple PRs if and where it's helpful for you.
Any ideas why that's happening / if it is affecting other pages or languages? All the other tasks seem like translation tasks, but if this is a bug maybe it is better to make a separate issue for it - unless you already have a fix. |
Hi @ksen0, I added some logs in the code file I checked other files dealing with multiple languages and found they use the
Related commit: 4678492 |
Closed as all related PRs got merged. |
As mentioned in #708 (comment), I have compiled a list of pages that are untranslated into Chinese.
contact.mdx
,copyright.mdx
,download.mdx
,privacy-policy.mdx
, andterms-of-use.mdx
are missing.about.mdx
is translated into Chinese, but it has some display issues as shown in https://p5js.org/zh-Hans/about/how-to-add-friendly-error-messages.mdx
,fes_contribution_guide.mdx
, anddocumentation_style_guide.mdx
are missing.how-to-add-friendly-error-messages.mdx
andfes_contribution_guide.mdx
were translated by me in PR [p5.js - zh(Hans)] translation of missing FES contribution docs p5.js#7667. I can just make a copy of them.documentation_style_guide.mdx
is also missing in the p5.js repo. Need to open a separate PR for it.@ksen0, can you please assign this issue to me?
I still have other questions:
privacy-policy.mdx
andterms-of-use.mdx
, these two documents contain a lot of legal terms. Should they be excluded from the translation and only the English version be retained to ensure accurate expression?The text was updated successfully, but these errors were encountered: