Skip to content

[PR] Fix #825 - Showing wrong errors' line numbers for .java files #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
processing-bot opened this issue Aug 19, 2024 · 4 comments
Closed

Comments

@processing-bot
Copy link
Collaborator

processing-bot commented Aug 19, 2024

This issue is a placeholder for a pull request. This is to ensure that issue numbers remain the same through the repository migration.

by e1dem

Fix for bug #825.

Using PreprocSketch.mapJavaToSketch result for processing .java files is incorrect, as a sketch's combined source code file does not include code from .java tabs.

As far as I can see, there is a similar issue with showing variables usage, so I would suggest this solution as a temporary one.

@SableRaf SableRaf changed the title Fix #825 - Showing wrong errors' line numbers for .java files - [opened] [PR] Fix #825 - Showing wrong errors' line numbers for .java files Aug 19, 2024
@SableRaf
Copy link
Collaborator

SableRaf commented Jan 24, 2025

Hey @e1dem are you still interested in this? If so would you mind re-submitting your PR (link)?

@e1dem
Copy link
Contributor

e1dem commented Jan 26, 2025

Hi @SableRaf. Yes, sure. Could you tell me, please, re-submitting a PR means just updating a commit date (I've done that) or something else?

@Stefterv
Copy link
Collaborator

Hi @e1dem, thank you for still being interested, this is a new repository so you will need to create a new fork, apply the same changes as before and open a new pull request

@e1dem
Copy link
Contributor

e1dem commented Jan 27, 2025

@Stefterv Thank you! @SableRaf, a PR to the new repository: link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants