Switching from vscode-tslint to vscode-tslint-vue makes only some tslint rules apply

[dkulchenko]

Keeping a .ts file open and disabling the tslint extension and enabling vscode-tslint-vue makes most of the tslint-related red squiggles disappear for me. Some rules (like max line length 100) still work just fine, but others (such as force single quote, or require semicolons) stop being in play. Not sure how to diagnose.

My tslint.json, if relevant:

{
  "defaultSeverity": "warning",
  "extends": "tslint-config-airbnb",
  "rules": {
    "import/no-extraneous-dependencies": ["error", {
      "optionalDependencies": ["test/unit/index.js"]
    }],
    "import-name": false,
    "align": [true, "parameters"],
    "quotemark": [true, "single", "avoid-escape"],
    "no-else-after-return": false
  }
}

[prograhammer]

Can you cook up an example project to replicate this problem and send me a link here on Github? One thing to consider is that this is a fork of vscode-tslint. So if you disable tslint-vscode-vue and try the same file with tslint-vscode extension and the single quote or require semicolon issue doesn't work in your ts file, then that means the problem is upstream.

[dkulchenko]

Sure thing - mini example project is here: https://github.com/dkulchenko/vscode-tslint-test-case

Opening up src/index.ts in VSC in that repo has proper squiggles for me with vscode-tslint enabled:

But not with vscode-tslint disabled and vscode-tslint-vue enabled:

[dkulchenko]

(Additional note: to make this work, I am hardcoding the path to the test project's tsconfig.json in tslint-vue-1.4.2/server/server.js, as discussed in issue #5, if that changes anything.)

[prograhammer]

Yeah, if you have it hardcoded, then the example project (https://github.com/dkulchenko/vscode-tslint-test-case) will not work. You hardcoded it for a specific project, remember?

[dkulchenko]

Yep - I'm saying I hardcoded it for the example project for the purposes of the test case. #5 went away, but not all the squiggles that should be showing are.

[prograhammer]

@dkulchenko I found out this is caused by two factors. The extension is using an older typescript version and also there's a flag missing I needed to set. So after I get back from dinner I'll release a new version that should fix this tonight.

[prograhammer]

@dkulchenko The bug is fixed. Let me know if it is working for you. Also, don't forget to find the 2 places where workspacePath || '' and replace the workspacePath with your hardcoded location of tsconfig.json (for now).

[dkulchenko]

All looks great now, thanks so much!