Skip to content

Commit e99e560

Browse files
Upgrade AppWrapper from v1.0.0 to v1.0.4
Features + Propagate SchedulingGates in RunWithPodSetsInfo + extend PodSets() to compute TopologyRequest + Support PreferNoSchedule labels for AutoPilot + Implement PodSet inference for JobSet Bugs and Regressions + move appwrapper finalizer injection from defaulting webhook to controller + use ptr.Equal to validate managedBy is immutable + fix handling of labels/annotations in utils.GetPodTemplateSpec
1 parent b7e3f34 commit e99e560

File tree

7 files changed

+32
-5
lines changed

7 files changed

+32
-5
lines changed

Diff for: Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ VERSION ?= v0.0.0-dev
1212
BUNDLE_VERSION ?= $(VERSION:v%=%)
1313

1414
# APPWRAPPER_VERSION defines the default version of the AppWrapper controller
15-
APPWRAPPER_VERSION ?= v1.0.0
15+
APPWRAPPER_VERSION ?= v1.0.4
1616
APPWRAPPER_REPO ?= github.com/project-codeflare/appwrapper
1717
APPWRAPPER_CRD ?= ${APPWRAPPER_REPO}/config/crd?ref=${APPWRAPPER_VERSION}
1818

Diff for: config/crd/appwrapper/kustomization.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
apiVersion: kustomize.config.k8s.io/v1beta1
22
kind: Kustomization
33
resources:
4-
- github.com/project-codeflare/appwrapper/config/crd?ref=v1.0.0
4+
- github.com/project-codeflare/appwrapper/config/crd?ref=v1.0.4

Diff for: config/crd/crd-appwrapper.yml

+14
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,20 @@ spec:
8888
type: string
8989
description: NodeSelectors to be added to the PodSpecTemplate
9090
type: object
91+
schedulingGates:
92+
description: SchedulingGates to be added to the PodSpecTemplate
93+
items:
94+
description: PodSchedulingGate is associated to a Pod to guard its scheduling.
95+
properties:
96+
name:
97+
description: |-
98+
Name of the scheduling gate.
99+
Each scheduling gate must have a unique name field.
100+
type: string
101+
required:
102+
- name
103+
type: object
104+
type: array
91105
tolerations:
92106
description: Tolerations to be added to the PodSpecTemplate
93107
items:

Diff for: config/rbac/role.yaml

+12
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,18 @@ rules:
164164
- get
165165
- list
166166
- watch
167+
- apiGroups:
168+
- jobset.x-k8s.io
169+
resources:
170+
- jobsets
171+
verbs:
172+
- create
173+
- delete
174+
- get
175+
- list
176+
- patch
177+
- update
178+
- watch
167179
- apiGroups:
168180
- kubeflow.org
169181
resources:

Diff for: go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ require (
1010
github.com/opendatahub-io/opendatahub-operator/v2 v2.10.0
1111
github.com/openshift/api v0.0.0-20240904015708-69df64132c91
1212
github.com/openshift/client-go v0.0.0-20240904130219-3795e907a202
13-
github.com/project-codeflare/appwrapper v1.0.0
13+
github.com/project-codeflare/appwrapper v1.0.4
1414
github.com/project-codeflare/codeflare-common v0.0.0-20250128135036-f501cd31fe8b
1515
github.com/ray-project/kuberay/ray-operator v1.2.2
1616
go.uber.org/zap v1.27.0

Diff for: go.sum

+2-2
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,8 @@ github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINE
223223
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
224224
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 h1:Jamvg5psRIccs7FGNTlIRMkT8wgtp5eCXdBlqhYGL6U=
225225
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
226-
github.com/project-codeflare/appwrapper v1.0.0 h1:tKvBXxaIE5RwzUC8YZvxcnbuz4JUbiuLjo1IWO4Mciw=
227-
github.com/project-codeflare/appwrapper v1.0.0/go.mod h1:pVCWURfk9DOa/4ig7z91PJWRMlsDchhQVmu7mB32L48=
226+
github.com/project-codeflare/appwrapper v1.0.4 h1:364zQLX0tsi4LvBBYNKZL7PPbNWPbVU7vK6+/kVV/FQ=
227+
github.com/project-codeflare/appwrapper v1.0.4/go.mod h1:A1b6bMFNMX5Btv3ckgeuAHVVZzp1G30pSBe6BE/xJWE=
228228
github.com/project-codeflare/codeflare-common v0.0.0-20250128135036-f501cd31fe8b h1:MOmv/aLx/kcHd7PBErx8XNSTW180s8Slf/uVM0uV4rw=
229229
github.com/project-codeflare/codeflare-common v0.0.0-20250128135036-f501cd31fe8b/go.mod h1:DPSv5khRiRDFUD43SF8da+MrVQTWmxNhuKJmwSLOyO0=
230230
github.com/prometheus/client_golang v1.20.5 h1:cxppBPuYhUnsO6yo/aoRol4L7q7UFfdm+bR9r+8l63Y=

Diff for: pkg/controllers/appwrapper_controller.go

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ package controllers
3232
//+kubebuilder:rbac:groups=kubeflow.org,resources=pytorchjobs,verbs=get;list;watch;create;update;patch;delete
3333
//+kubebuilder:rbac:groups=ray.io,resources=rayclusters,verbs=get;list;watch;create;update;patch;delete
3434
//+kubebuilder:rbac:groups=ray.io,resources=rayjobs,verbs=get;list;watch;create;update;patch;delete
35+
//+kubebuilder:rbac:groups=jobset.x-k8s.io,resources=jobsets,verbs=get;list;watch;create;update;patch;delete
3536

3637
// permissions needed by Kueue's generic reconciller
3738
// +kubebuilder:rbac:groups=scheduling.k8s.io,resources=priorityclasses,verbs=list;get;watch

0 commit comments

Comments
 (0)