Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers are off if \r\n is used #84

Open
rcjsuen opened this issue Jul 19, 2017 · 0 comments
Open

Line numbers are off if \r\n is used #84

rcjsuen opened this issue Jul 19, 2017 · 0 comments

Comments

@rcjsuen
Copy link

rcjsuen commented Jul 19, 2017

dockerfile_lint warns about errors being on lines 3 and 5 but it should really be on lines 2 and 3. It's not splitting the \r\n characters as a set.

image

> cat Dockerfile.test
FROM busybox
HEALTHCHECK cmd
HEALTHCHECK cmd
> node bin\dockerfile_lint -f Dockerfile.test

--------ERRORS---------

Line 3: -> HEALTHCHECK cmd
ERROR: A HEALTHCHECK instruction must specify either NONE, or a valid CMD and options.
Reference -> https://docs.docker.com/engine/reference/builder/


Line 5: -> HEALTHCHECK cmd
ERROR: A HEALTHCHECK instruction must specify either NONE, or a valid CMD and options.
Reference -> https://docs.docker.com/engine/reference/builder/


ERROR: Required LABEL name/key 'Name' is not defined.
Reference -> http://docs.projectatomic.io/container-best-practices/#_recommended_labels_for_your_project


ERROR: Required LABEL name/key 'Version' is not defined.
Reference -> http://docs.projectatomic.io/container-best-practices/#_recommended_labels_for_your_project



--------INFO---------

INFO: There is no 'EXPOSE' instruction. Without exposed ports how will the service of the container be accessed?.
Reference -> https://docs.docker.com/engine/reference/builder/#expose


INFO: There is no 'CMD' instruction. None.
Reference -> https://docs.docker.com/engine/reference/builder/#cmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant