From 0bc3d9fdb50ddada1cc60e98f95897e8c3187263 Mon Sep 17 00:00:00 2001 From: Peter Dave Hello Date: Wed, 20 May 2020 17:53:13 +0800 Subject: [PATCH] Remove unnecessary rule no_apt-get_clean, fix #125 Reference: - https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#apt-get --- config/default_rules.yaml | 9 --------- sample_rules/basic_rules.yaml | 9 --------- sample_rules/basic_rules_atomic.yaml | 9 --------- sample_rules/default_rules.yaml | 9 --------- sample_rules/openshift.yaml | 9 --------- sample_rules/osbs.yaml | 9 --------- 6 files changed, 54 deletions(-) diff --git a/config/default_rules.yaml b/config/default_rules.yaml index 66d2741..39bed25 100644 --- a/config/default_rules.yaml +++ b/config/default_rules.yaml @@ -153,15 +153,6 @@ reference_url: - "http://docs.projectatomic.io/container-best-practices/#" - "_clear_packaging_caches_and_temporary_package_downloads" - - - label: "no_apt-get_clean" - regex: /apt-get install(?!.+clean)/g - level: "info" - message: "apt-get clean is not used" - description: "the apt-get cache will remain in this layer making the layer unnecessarily large" - reference_url: - - "http://docs.projectatomic.io/container-best-practices/#" - - "_clear_packaging_caches_and_temporary_package_downloads" - label: "privileged_run_container" regex: /privileged/ diff --git a/sample_rules/basic_rules.yaml b/sample_rules/basic_rules.yaml index 4690472..daf710d 100644 --- a/sample_rules/basic_rules.yaml +++ b/sample_rules/basic_rules.yaml @@ -162,15 +162,6 @@ reference_url: - "http://docs.projectatomic.io/container-best-practices/#" - "_clear_packaging_caches_and_temporary_package_downloads" - - - label: "no_apt-get_clean" - regex: /apt-get install(?!.+clean)/g - level: "warn" - message: "apt-get clean is not used" - description: "the apt-get cache will remain in this layer making the layer unnecessarily large" - reference_url: - - "http://docs.projectatomic.io/container-best-practices/#" - - "_clear_packaging_caches_and_temporary_package_downloads" - label: "privileged_run_container" regex: /privileged/ diff --git a/sample_rules/basic_rules_atomic.yaml b/sample_rules/basic_rules_atomic.yaml index 41dca23..ce30724 100644 --- a/sample_rules/basic_rules_atomic.yaml +++ b/sample_rules/basic_rules_atomic.yaml @@ -162,15 +162,6 @@ reference_url: - "http://docs.projectatomic.io/container-best-practices/#" - "_clear_packaging_caches_and_temporary_package_downloads" - - - label: "no_apt-get_clean" - regex: /apt-get install(?!.+clean)/g - level: "warn" - message: "apt-get clean is not used" - description: "the apt-get cache will remain in this layer making the layer unnecessarily large" - reference_url: - - "http://docs.projectatomic.io/container-best-practices/#" - - "_clear_packaging_caches_and_temporary_package_downloads" - label: "privileged_run_container" regex: /privileged/ diff --git a/sample_rules/default_rules.yaml b/sample_rules/default_rules.yaml index b45d653..f619e15 100644 --- a/sample_rules/default_rules.yaml +++ b/sample_rules/default_rules.yaml @@ -144,15 +144,6 @@ reference_url: - "http://docs.projectatomic.io/container-best-practices/#" - "_clear_packaging_caches_and_temporary_package_downloads" - - - label: "no_apt-get_clean" - regex: /apt-get install(?!.+clean)/g - level: "info" - message: "apt-get clean is not used" - description: "the apt-get cache will remain in this layer making the layer unnecessarily large" - reference_url: - - "http://docs.projectatomic.io/container-best-practices/#" - - "_clear_packaging_caches_and_temporary_package_downloads" - label: "privileged_run_container" regex: /privileged/ diff --git a/sample_rules/openshift.yaml b/sample_rules/openshift.yaml index 826b3e7..d465ad2 100644 --- a/sample_rules/openshift.yaml +++ b/sample_rules/openshift.yaml @@ -150,15 +150,6 @@ reference_url: - "http://docs.projectatomic.io/container-best-practices/#" - "_clear_packaging_caches_and_temporary_package_downloads" - - - label: "no_apt-get_clean" - regex: /apt-get install(?!.+clean)/g - level: "warn" - message: "apt-get clean is not used" - description: "the apt-get cache will remain in this layer making the layer unnecessarily large" - reference_url: - - "http://docs.projectatomic.io/container-best-practices/#" - - "_clear_packaging_caches_and_temporary_package_downloads" - label: "privileged_run_container" regex: /privileged/ diff --git a/sample_rules/osbs.yaml b/sample_rules/osbs.yaml index a0f5c06..18a3e22 100644 --- a/sample_rules/osbs.yaml +++ b/sample_rules/osbs.yaml @@ -149,15 +149,6 @@ reference_url: - "http://docs.projectatomic.io/container-best-practices/#" - "_clear_packaging_caches_and_temporary_package_downloads" - - - label: "no_apt-get_clean" - regex: /apt-get install(?!.+clean)/g - level: "warn" - message: "apt-get clean is not used" - description: "the apt-get cache will remain in this layer making the layer unnecessarily large" - reference_url: - - "http://docs.projectatomic.io/container-best-practices/#" - - "_clear_packaging_caches_and_temporary_package_downloads" - label: "privileged_run_container" regex: /privileged/