Easier override for Arclight::BookmarkComponent
#1560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will make it easier to override the `Arclight::BookmarkComponent` where all you would have to do is add it to the `CatalogController`. Other components should reference that and have a fallback to the original `Arclight::BookmarkComponent`
cbeer
reviewed
Oct 21, 2024
| <% end %> | ||
| <%= render 'arclight/requests', document: document %> | ||
| <%= render Arclight::BookmarkComponent.new document: document, action: bookmark_config %> | ||
| <%= render (blacklight_config.index.document_actions.arclight_bookmark_control.component || Arclight::BookmarkComponent).new document: document, action: bookmark_config %> |
There was a problem hiding this comment.
Suggested change
| <%= render (blacklight_config.index.document_actions.arclight_bookmark_control.component || Arclight::BookmarkComponent).new document: document, action: bookmark_config %> | |
| <%= render (presenter&.view_config&.document_actions&.arclight_bookmark_control.component || Arclight::BookmarkComponent).new document: document, action: bookmark_config %> |
I think the presenter should have the appropriate configuration context, maybe?
There was a problem hiding this comment.
Hey @cbeer, I don't seem to be finding what I'm looking for using the presenter view_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will make it easier to override the
Arclight::BookmarkComponentwhere all you would have to do is add it to theCatalogController. Other components should reference that and have a fallback to the originalArclight::BookmarkComponent