[quality] build/00-image-info.sh and build/10-build.sh are untestable — no filesystem root override

[kubestellar-hive]

Finding

After PR #285, build/clean-stage.sh and build/copr-helpers.sh have BATS coverage. The other two build scripts do not, and cannot be unit tested as written:

build/00-image-info.sh (93 lines) — writes to hardcoded absolute paths:

• IMAGE_INFO="/usr/share/ublue-os/image-info.json"
• OS_RELEASE="/usr/lib/os-release"

Untested logic worth covering: the IMAGE_FLAVOR derivation (nvidia vs main from a regex on IMAGE_NAME), the IMAGE_REF string used by bootc as the upgrade source, JSON field correctness, the VERSION vs UBLUE_IMAGE_TAG fallback for IMAGE_VERSION, and the VARIANT_ID guard that makes the os-release append idempotent. A malformed image-ref here silently breaks bootc upgrade for every user of the image.

build/10-build.sh (67 lines) — sources /ctx/build/copr-helpers.sh by absolute path and calls rsync, dnf5, systemctl, cp, find against /ctx and /usr. Untested behaviour: nullglob is enabled specifically so the custom/brew/*.Brewfile and custom/flatpaks/*.preinstall copies do not fail on empty matches — but cp with an unmatched glob under nullglob receives no source argument and fails anyway, which no test would currently catch.

Recommendation

Adopt the same prefix hook clean-stage.sh already uses (CLEAN_ROOT):

1. In 00-image-info.sh, introduce a defaulted prefix, e.g.
   IMAGE_ROOT="${IMAGE_ROOT:-/}", and build IMAGE_INFO/OS_RELEASE from it. Production behaviour is unchanged (prefix defaults to /); tests can point it at a temp dir.
2. In 10-build.sh, take the context dir from ${CTX_DIR:-/ctx} and the install prefix from ${BUILD_ROOT:-} so the copy/consolidate section can run in a sandbox with stubbed dnf5/systemctl/rsync.
3. Add tests/unit/00-image-info_test.bats and tests/unit/10-build_test.bats following the stub-PATH pattern established in [quality] test: add BATS unit tests for build/clean-stage.sh and build/copr-helpers.sh #285.

Step 1 and 2 are production edits, so the quality agent is not opening a PR for them — a maintainer should make the hook change, after which the tests can be contributed.

Priority

• Impact: high (image-ref and os-release correctness gate bootc upgrades)
• Effort: medium

Related

• PR [quality] test: add BATS unit tests for build/clean-stage.sh and build/copr-helpers.sh #285 — existing BATS suite and stub conventions
• Issue [quality] No CI workflow runs the new BATS unit tests (tests/unit/) #286 — CI wiring to actually run the suite

---

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: unknown

— hive: agent=quality backend=copilot model=claude-opus-5

[github-actions]

The workflow labels were repaired to 2-discussing. Keep exactly one workflow state label; blocked and hold may be used as overlays.

[kubestellar-hive]

Update: the production prefix hooks (steps 1 and 2 of the recommendation) turned out to be unnecessary. Both scripts are testable as-written using the sandbox rewrite pattern already used in the bluefin BATS suites — copy the script to a temp dir, sed its hardcoded absolute paths onto a sandbox root, and stub rsync/dnf5/systemctl on PATH. Each suite opens with a guard test asserting the rewrite applied, so path drift fails loudly instead of writing to the host.

PR #295 delivers step 3 only — tests/unit/00-image-info_test.bats (20 tests) and tests/unit/10-build_test.bats (17 tests), 37 passing, no production file touched. It covers the IMAGE_FLAVOR derivation, the ostree-image-signed image-ref, the VERSION/UBLUE_IMAGE_TAG fallback and the VARIANT_ID idempotency guard, plus the 10-build.sh copy/consolidate/enable steps.

The nullglob finding in this issue is now pinned by two regression guards: an empty custom/brew/ or custom/flatpaks/ still fails the build, because cp receives no source argument. Making those copies genuinely optional remains a production change for a maintainer.

---

quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-projectbluefin-knuckle-gjvq | SHA: ec487a3

— hive: agent=quality backend=copilot model=claude-opus-5