systemd.go: Do not report IPAccounting data when IPAccounting=no or irrelevant

jcgl17 · jcgl17 · commit 80e1e8e7fd7d · 2025-08-06T01:12:37.000+02:00
Signed-off-by: j &lt;j@cgl.sh&gt;
diff --git a/systemd/systemd.go b/systemd/systemd.go
@@ -727,8 +727,11 @@ func (c *Collector) collectIPAccountingMetrics(conn *dbus.Conn, ch chan<- promet
 			return fmt.Errorf(errConvertUint64PropertyMsg, propertyName, property.Value.Value())
 		}
 
-		ch <- prometheus.MustNewConstMetric(desc, prometheus.CounterValue,
-			float64(counter), unit.Name)
+		// Don't set if dbus reports MaxUint64.
+		if counter != math.MaxUint64 {
+			ch <- prometheus.MustNewConstMetric(desc, prometheus.CounterValue,
+				float64(counter), unit.Name)
+		}
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -727,8 +727,11 @@ func (c Collector) collectIPAccountingMetrics(conn dbus.Conn, ch chan<- promet`
`727`	`727`	`return fmt.Errorf(errConvertUint64PropertyMsg, propertyName, property.Value.Value())`
`728`	`728`	`}`
`729`	`729`
`730`		`- ch <- prometheus.MustNewConstMetric(desc, prometheus.CounterValue,`
`731`		`- float64(counter), unit.Name)`
	`730`	`+ // Don't set if dbus reports MaxUint64.`
	`731`	`+ if counter != math.MaxUint64 {`
	`732`	`+ ch <- prometheus.MustNewConstMetric(desc, prometheus.CounterValue,`
	`733`	`+ float64(counter), unit.Name)`
	`734`	`+ }`
`732`	`735`	`}`
`733`	`736`
`734`	`737`	`return nil`