Translation with custom bind bugfix (#5)

Author: pascalbaljet

src/Components/HandlesDefaultAndOldValue.php

@@ -22,7 +22,9 @@ private function setValue(
             return $this->value = old($name, $default);
         }
 
-        $bind = $this->getBoundTarget($bind, $name);
+        if ($bind !== false) {
+            $bind = $bind ?: $this->getBoundTarget();
+        }
 
         if ($bind) {
             $default = $bind->getTranslation($name, $language, false) ?: $default;

tests/Feature/TranslatableModel.php

@@ -9,5 +9,5 @@ class TranslatableModel extends Model
 {
     use HasTranslations;
 
-    public $translatable = ['input'];
+    public $translatable = ['input', 'output'];
 }

tests/Feature/TranslationTest.php

@@ -27,6 +27,16 @@ public function it_can_bind_a_target_to_the_form()
             ->seeElement('input[name="input[en]"][value="hello"]');
     }
 
+    /** @test */
+    public function it_can_override_the_bind_with_a_different_target()
+    {
+        $this->registerTestRoute('translation-with-bind');
+
+        $this->visit('/translation-with-bind')
+            ->seeElement('input[name="output[nl]"][value="vaarwel"]')
+            ->seeElement('input[name="output[en]"][value="goodbye"]');
+    }
+
     /** @test */
     public function it_shows_the_validation_errors_and_old_values_correctly()
     {

tests/Feature/views/translation-with-bind.blade.php

@@ -1,12 +1,18 @@
 @php
-    $target = new \ProtoneMedia\LaravelFormComponents\Tests\Feature\TranslatableModel;
-    $target->setTranslations('input', ['nl' => 'hallo', 'en' => 'hello']);
+    $targetA = new \ProtoneMedia\LaravelFormComponents\Tests\Feature\TranslatableModel;
+    $targetA->setTranslations('input', ['nl' => 'hallo', 'en' => 'hello']);
+
+    $targetB = new \ProtoneMedia\LaravelFormComponents\Tests\Feature\TranslatableModel;
+    $targetB->setTranslations('output', ['nl' => 'vaarwel', 'en' => 'goodbye']);
 @endphp
 
 <x-form>
-    @bind($target)
+    @bind($targetA)
         <x-form-input name="input" language="nl" />
+        <x-form-input name="output" language="nl" :bind="$targetB" />
+
         <x-form-input name="input" language="en" />
+        <x-form-input name="output" language="en" :bind="$targetB" />
 
         <x-form-submit />
     @endbind