Map fields

[bagrusss]

I have message with map field:
message PairsMsg {
...
map<string, string> pairs = 1;
...
}
and got this error
ERROR i.p.c.c.ProtostuffCompilerCli - Unknown option: 'map_entry' [unknown]

[kshchepanovskyi]

Are you using custom google/protobuf/descriptor.proto?

[kshchepanovskyi]

This option comes from here: https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L451

[bagrusss]

No, I have not this option.

[bagrusss]

Is there any progress on this issue?
When about wait for the support of the map fields?

[kshchepanovskyi]

Map fields are fully supported and covered by tests:

• https://github.com/protostuff/protostuff-compiler/blob/master/protostuff-it/src/test/proto/io/protostuff/it/message.proto#L21
• https://github.com/protostuff/protostuff-compiler/blob/master/protostuff-it/src/test/java/io/protostuff/it/java/MessageTest.java

Please create some minimal project that reproduces an issue, then I will be able to help.

[bagrusss]

I use custom descriptor.proto, but without map_entry option.
Here is an example, when protostuff compiler fails with ERROR i.p.c.c.ProtostuffCompilerCli - Unknown option: 'map_entry' [unknown]

Removing optional string experimental_map_key = 9; provides nothing.

[kshchepanovskyi]

You must upgrade your descriptor.proto to the new one, which contains map_entry option.
You can take it from https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto

Your version of this file is old, it comes from protoc version that did not support maps.