Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages produce: Support TopicRecordNameStrategy & RecordNameStrategy #1361

Open
iliax opened this issue Jan 8, 2022 · 8 comments
Open
Assignees
Labels
area/serde Serialization & Deserialization (plugins) area/sr Schema Registry scope/backend scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Milestone

Comments

@iliax
Copy link
Contributor

iliax commented Jan 8, 2022

Is your proposal related to a problem?

Currently when producing message only TopicNameStrategy used to search appropriate subjects. If subject is not found by this strategy message is written as raw text. If user uses TopicRecordNameStrategy or RecordNameStrategy text msg will be written which can break downstream consumption.

Describe the solution you'd like

  • on "Produce Message" page we should show which schema will be used for serialization
  • if no schema found by TopicNameStrategy for topic we should be able to specify schema explicitly - there should be a dropdown with all subject names
  • if schema not found and not specified then message will be treated as a text

Implementation

Backend:

  • add keySubject and valueSubject fields to produce endpoint

Frontend:

  • TODO: discuss

--
More details: #3244

@iliax iliax added type/enhancement En enhancement to an already existing feature scope/backend scope/frontend labels Jan 8, 2022
@github-actions github-actions bot added the status/triage Issues pending maintainers triage label Jan 8, 2022
@iliax
Copy link
Contributor Author

iliax commented Jan 8, 2022

relates to ISSUE: #1356

@iliax
Copy link
Contributor Author

iliax commented Jan 8, 2022

@Haarolean I suggest to add this to next release worklog, since this already affected some users in a bad way

@Haarolean Haarolean added status/accepted An issue which has passed triage and has been accepted and removed status/triage Issues pending maintainers triage labels Jan 10, 2022
@Haarolean Haarolean added this to the 0.4 milestone Jan 10, 2022
@Haarolean Haarolean added the good first issue Up for grabs label Jan 10, 2022
@iliax iliax removed the good first issue Up for grabs label Jan 12, 2022
@Haarolean Haarolean added the status/needs-attention Collective discussion is required label Feb 9, 2022
@Haarolean Haarolean modified the milestones: 0.4, 0.5 Feb 9, 2022
@Haarolean Haarolean removed this from the 0.5 milestone Sep 13, 2022
@Haarolean Haarolean added status/blocked Further development process is blocked by something. Prevents merging for PRs. and removed status/needs-attention Collective discussion is required labels Sep 20, 2022
@Haarolean
Copy link
Contributor

#2125

@Haarolean Haarolean added the status/needs-attention Collective discussion is required label Sep 20, 2022
@Shawcs
Copy link

Shawcs commented Jan 10, 2023

+1
This issue is only for producing a message with a different strategy but in the same time it will be also coherent to have it for the consumption (hense the deserialization).

@vsevel
Copy link

vsevel commented Jan 11, 2023

very important for us. thanks.

@Haarolean Haarolean added this to the 0.7 milestone Mar 14, 2023
@Haarolean Haarolean removed the status/blocked Further development process is blocked by something. Prevents merging for PRs. label Mar 14, 2023
@Haarolean Haarolean modified the milestones: 0.7, 0.8 Apr 24, 2023
@Haarolean Haarolean removed the status/needs-attention Collective discussion is required label Apr 24, 2023
@Haarolean Haarolean removed this from the 0.8 milestone May 11, 2023
@Haarolean Haarolean added this to the 0.9 milestone May 11, 2023
@Haarolean Haarolean added area/sr Schema Registry area/serde Serialization & Deserialization (plugins) labels May 18, 2023
@cdia8890
Copy link

I would love to contribute to implementing this feature. This is an important feature we're looking forward to.

@SujithPS0604
Copy link

SujithPS0604 commented Jul 25, 2024

Hello folks! Is there any update on this issue? We are eagerly waiting for the feature.

@Haarolean
Copy link
Contributor

@SujithPS0604 #4255 -> https://github.com/kafbat/kafka-ui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serde Serialization & Deserialization (plugins) area/sr Schema Registry scope/backend scope/frontend status/accepted An issue which has passed triage and has been accepted type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

No branches or pull requests

6 participants