Skip to content

Topic analysis improvements #2674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Haarolean opened this issue Sep 30, 2022 · 6 comments · Fixed by #2691 or #4123
Closed

Topic analysis improvements #2674

Haarolean opened this issue Sep 30, 2022 · 6 comments · Fixed by #2691 or #4123
Assignees
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted status/design-review type/enhancement En enhancement to an already existing feature
Milestone

Comments

@Haarolean
Copy link
Contributor

Haarolean commented Sep 30, 2022

image

  • Display percentage in %

  • Display time passed since the start

  • Split "scanned messages" to two lines: "scanned messages" and "scanned bytes"

@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/frontend status/accepted An issue which has passed triage and has been accepted labels Sep 30, 2022
@Haarolean Haarolean added this to the 0.5 milestone Sep 30, 2022
@BulatKha
Copy link
Contributor

BulatKha commented Nov 8, 2022

@Haarolean it looks almost according the way you suggested. However the overall progress percentage and progress bar look a bit strange now:
image

Suggestion: Show the percentage above the progress bar, using a bigger font (most important info in the block, while the rest is additional info).
And the progress bar width to be matched to block width and it's alignment to the center. So it would be more consistent.

Should it be created as a separate improvement task or fixed here while we are at it anyway?

CC @armenuikafka

@Haarolean Haarolean reopened this Nov 8, 2022
@Haarolean Haarolean added the good first issue Up for grabs label Nov 14, 2022
@Haarolean Haarolean modified the milestones: 0.5, 0.6 Nov 14, 2022
@Haarolean Haarolean self-assigned this Dec 13, 2022
@Haarolean Haarolean removed their assignment Mar 6, 2023
@Haarolean Haarolean removed this from the 0.6 milestone Mar 6, 2023
@pradyumnad
Copy link
Contributor

pradyumnad commented Aug 15, 2023

pct_statistics
Were you looking for something like this? @BulatKha
I can submit a PR, can you assign this to me? @Haarolean

@Haarolean
Copy link
Contributor Author

@pradyumnad that's better, yes

@pradyumnad
Copy link
Contributor

@Haarolean PR submitted #4123

@BulatKha
Copy link
Contributor

@Haarolean @pradyumnad just a minor comment to fix the alignment of the progress bar, as it looks a bit sideways. Centered and stretched from the left edge of the text to the right border of the second column would look better.
Looks fine otherwise!

@pradyumnad
Copy link
Contributor

@BulatKha yes, I was just fiddling with Pixelmator to kind of get the idea. The code was done to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted status/design-review type/enhancement En enhancement to an already existing feature
Projects
Status: Done
4 participants