Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Topics] Retention bytes custom parameter overrides the "Max size on disk in GB" value within Topic #3270

Open
armenuikafka opened this issue Jan 26, 2023 · 1 comment
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/bug Something isn't working

Comments

@armenuikafka
Copy link

Describe the bug (Actual behavior)
When user is selecting "Max size on disk in GB" value (10 GB) and then add the Custom parameter "Retention bytes" with any value, after saving and editing the Topic, added custom parameter keeps and "Max size on disk in GB" value returns to "Not Set"

Expected behavior

  • If the "Max size on disk in GB" is selected, "Retention bytes" can be removed from Custom parameter dropdown values
  • If user lets "Max size on disk in GB" to be "Not set" or select any value (1, 10, 20, 50 GB) and then add the Retention bytes, after Topic save, the value of custom retention bytes can be displayed in "Max size on disk in GB" instead of "Not set"
  • Suggested to change "Max size on disk in GB" to be "Max size on disk "

Set up
https://www.kafka-ui.provectus.io/

Steps to Reproduce

  1. Navigate to Topics
  2. Add required data
  3. Select "10 GB" for " "Max size on disk in GB"
  4. Add custom parameter
  5. Select retention bytes
  6. Fill value
  7. Save the Topic
  8. Press "Edit settings" from 3dot menu

Screenshots

retentionbytes.mov

Additional context
relates to #3071

@armenuikafka armenuikafka added type/bug Something isn't working status/triage Issues pending maintainers triage labels Jan 26, 2023
@Haarolean Haarolean added status/accepted An issue which has passed triage and has been accepted status/needs-attention Collective discussion is required and removed status/triage Issues pending maintainers triage labels Feb 23, 2023
@Haarolean
Copy link
Contributor

TODO:

  1. Create separate fields for the numeric value and a unit value (mb/gb)
  2. Remove the custom field at all

@Haarolean Haarolean added good first issue Up for grabs scope/frontend and removed status/needs-attention Collective discussion is required labels Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Up for grabs scope/frontend status/accepted An issue which has passed triage and has been accepted type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants