Skip to content

Commit e6b3e19

Browse files
committed
feat(cli): add --browser-timeout-sec argument, default 10min
1 parent 777a6c2 commit e6b3e19

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

commands/run.js

+7-2
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,11 @@ exports.builder = {
119119
default: true,
120120
desc: 'Whether to post images of fire locations',
121121
},
122+
browserTimeoutSec: {
123+
number: true,
124+
default: 600,
125+
desc: 'Timeout for rendering pages in browser (seconds)',
126+
},
122127
redo: {
123128
string: true,
124129
desc: 'Forces an update of a given fire ids (comma separated)',
@@ -806,11 +811,11 @@ exports.handler = (argv) => {
806811
}
807812

808813
async function renderPerim() {
809-
return render.renderInBrowser(2232, 1450, perimWebpageUrl, perimImg);
814+
return render.renderInBrowser(2232, 1450, perimWebpageUrl, perimImg, argv.browserTimeoutSec);
810815
}
811816

812817
async function renderUpdateImage() {
813-
return render.renderInBrowser(2048, 1330, mainWebpageUrl, infoImg);
818+
return render.renderInBrowser(2048, 1330, mainWebpageUrl, infoImg, argv.browserTimeoutSec);
814819
}
815820
}
816821
}

lib/render.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ limitations under the License.
1818

1919
const puppeteer = require('puppeteer');
2020

21-
exports.renderInBrowser = async function(width, height, url, outPath) {
21+
exports.renderInBrowser = async function(width, height, url, outPath, timeoutSec) {
2222
const browser = await puppeteer.launch({
2323
defaultViewport: {
2424
width: width, height: height,
@@ -27,7 +27,7 @@ exports.renderInBrowser = async function(width, height, url, outPath) {
2727
});
2828
const page = await browser.newPage();
2929
await page.goto(url, {
30-
timeout: 60000 * 10,
30+
timeout: 1000 * timeoutSec,
3131
waitUntil: 'networkidle0',
3232
});
3333
await page.screenshot({

0 commit comments

Comments
 (0)