Skip to content

Commit 18959aa

Browse files
committed
floogen(test): Fix unit tests
1 parent 0b6f1ce commit 18959aa

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

floogen/model/routing.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -367,16 +367,13 @@ def trim(self):
367367
# Validate the routing table
368368
self.model_validate(self)
369369

370-
def render(self, **kwargs):
370+
def render(self, aw=None):
371371
"""Render the SystemVerilog routing table."""
372372
string = ""
373373
rules = self.rules.copy()
374-
if "id_offset" in kwargs and kwargs["id_offset"] is not None:
375-
for rule in rules:
376-
rule.dest -= kwargs["id_offset"]
377374
# typedef of the address rule
378375
string += sv_param_decl(f"{snake_to_camel(self.name)}NumRules", len(rules)) + "\n"
379-
addr_type = f"logic [{kwargs["aw"]-1}:0]" if "aw" in kwargs else "id_t"
376+
addr_type = f"logic [{aw-1}:0]" if aw is not None else "id_t"
380377
rule_type_dict = {}
381378
rule_type_dict = {"idx": "id_t", "start_addr": addr_type, "end_addr": addr_type}
382379
string += sv_struct_typedef(self.rule_type(), rule_type_dict)
@@ -389,7 +386,7 @@ def render(self, **kwargs):
389386
)
390387
return string
391388
for i, rule in enumerate(rules):
392-
rules_str += f"{rule.render(**kwargs)}"
389+
rules_str += f"{rule.render(aw)}"
393390
rules_str += ',' if i != len(rules) - 1 else ' '
394391
if rule.desc is not None:
395392
rules_str += f"// {rule.desc}\n"

floogen/tests/address_test.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def test_routing_table_len():
7676
"""Test the length of a RoutingTable object."""
7777
rule1 = RouteMapRule(addr_range=AddrRange(start=0, end=10), dest=SimpleId(id=1))
7878
rule2 = RouteMapRule(addr_range=AddrRange(start=11, end=20), dest=SimpleId(id=2))
79-
routing_table = RouteMap(rules=[rule1, rule2])
79+
routing_table = RouteMap(name="test_map", rules=[rule1, rule2])
8080
assert len(routing_table) == 2
8181

8282

@@ -85,7 +85,7 @@ def test_check_no_overlapping_ranges():
8585
rule1 = RouteMapRule(addr_range=AddrRange(start=0, end=10), dest=SimpleId(id=1))
8686
rule2 = RouteMapRule(addr_range=AddrRange(start=5, end=15), dest=SimpleId(id=2))
8787
with pytest.raises(ValueError):
88-
RouteMap(rules=[rule1, rule2])
88+
RouteMap(name="test_map", rules=[rule1, rule2])
8989

9090

9191
def test_trim():
@@ -94,7 +94,7 @@ def test_trim():
9494
rule2 = RouteMapRule(addr_range=AddrRange(start=10, end=20), dest=SimpleId(id=1))
9595
rule3 = RouteMapRule(addr_range=AddrRange(start=20, end=30), dest=SimpleId(id=2))
9696
rule4 = RouteMapRule(addr_range=AddrRange(start=31, end=40), dest=SimpleId(id=2))
97-
routing_table = RouteMap(rules=[rule1, rule2, rule3, rule4])
97+
routing_table = RouteMap(name="test_map", rules=[rule1, rule2, rule3, rule4])
9898
routing_table.trim()
9999
expected_rules = [
100100
RouteMapRule(addr_range=AddrRange(start=0, end=20), dest=SimpleId(id=1)),

0 commit comments

Comments
 (0)