[language-csharp] Collection of various missing syntax highlighting

[ditpowuh]

Thanks in advance for your bug report!

• Have you reproduced issue in safe mode?
• Have you used the debugging guide to try to resolve the issue?
• Have you checked our FAQs to make sure your question isn't answered there?
• Have you checked to make sure your issue does not already exist?
• Have you checked you are on the latest release of Pulsar?

What happened?

Several syntax highlighting are missing with the new tree-sitter grammar in language-csharp

• Comparison operators
• new operator
• readonly keyword
• String interpolation using $
• async keyword
• Attributes (e.g. [Serializable])

Other syntax highlighting issues:

• The method part in generic method calls appear in the same highlighting color as the type
• Instance method calls highlight differently to unqualified method calls

Apologies if this is a lot

Pulsar version

1.132.1

Which OS does this happen on?

🪟 Windows

OS details

Windows 11

Which CPU architecture are you running this on?

x86_64/AMD64

What steps are needed to reproduce this?

1. Create C# file
2. Use the items above

Additional Information:

Screenshot of random code, containing example for each of the above

I'll keep an eye out if there is any more and follow up with them here

[savetheclocktower]

Apologies if this is a lot

No, this is perfect. Thanks! We should be able to fix this for 1.133.0.

[savetheclocktower]

OK, these were all easy enough to fix and did not require a parser update:

You're the first one to complain about the C# highlighting, but there was clearly plenty to complain about!

PR incoming.

[ditpowuh]

Amazing work as always. Thank you!

[ditpowuh]

Hi again, I've been using the language-csharp package from the tree-sitter fixes branch and found some more things to add on.

• Attributes not highlighted when fully qualified
• Fully qualified types are not highlighted (both in declaration and in generic method calls)
• try and switch keywords not highlighted
• Different highlighting with accessing properties in functions v.s. when accessing them outside (e.g. in assignment)
• Unqualified generic method calls are not highlighted

Screenshot of random code, containing examples to make it clearer:

[savetheclocktower]

OK, just pushed to #1577 again. Shortly you'll be able to download a new binary to test from this CI job!

I got tired of marking the same types in 20 different contexts, so I think I figured out a more generic way to scope them. But let me know if anything regressed!

[ditpowuh]

Looking great! C# codebase I'm working in is looking super readable!

One issue I did notice however while testing, it seems generic method calls have the type highlighted only when with a built-in type; with any other type (i.e. not int, bool, string, etc.), it does not highlight:

Adding on to that, while I'd consider this non-critical and could probably live with it, it also seems to occur with instantiation:

Other than that, everything's perfect!

[savetheclocktower]

Cool! I'll see if I can fix that tonight. Should only take a few minutes!