Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass python SDK version into release verification #1219

Closed
danielrbradley opened this issue Dec 12, 2024 · 0 comments · Fixed by #1220
Closed

Pass python SDK version into release verification #1219

danielrbradley opened this issue Dec 12, 2024 · 0 comments · Fixed by #1220
Assignees
@danielrbradley
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@danielrbradley
Copy link
Member

For pre-releases of SDKs, the Python package version is transformed by codegen to be compatible with PyPi's version format (which is not semver v2). When we attempt to fetch the PyPi package based on the provider version it will never be found for python prereleases.

Therefore, we need to extract the generated python package version and pass it into the verify-provider-release packageVersion field.

Related issues:
@danielrbradley danielrbradley added the kind/bug Some behavior is incorrect or out of spec label Dec 12, 2024
@danielrbradley danielrbradley self-assigned this Dec 12, 2024
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 12, 2024
@danielrbradley danielrbradley mentioned this issue Dec 12, 2024
Closed
@danielrbradley danielrbradley removed the needs-triage Needs attention from the triage team label Dec 12, 2024
danielrbradley added a commit that referenced this issue Dec 12, 2024
@danielrbradley
Verify actual published Python SDK version
b8ae851 
Fixes #1219

Extract SDK version after publishing the Python SDK. The SDK is downloaded internally by the pulumi-package-publisher action.
@danielrbradley danielrbradley mentioned this issue Dec 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@danielrbradley
Verify actual published Python SDK version (#1220)
84bf03d 
Fixes #1219

Extract SDK version after publishing the Python SDK. The SDK is
downloaded internally by the pulumi-package-publisher action.

The xyz provider does not have a python example so we will need to
manually test this against another provider.
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielrbradley danielrbradley

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Verify actual published Python SDK version pulumi/ci-mgmt
2 participants
@danielrbradley @pulumi-bot