Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify actual published Python SDK version #1220

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Dec 12, 2024

Fixes #1219

Extract SDK version after publishing the Python SDK. The SDK is downloaded internally by the pulumi-package-publisher action.

The xyz provider does not have a python example so we will need to manually test this against another provider.

Fixes #1219

Extract SDK version after publishing the Python SDK. The SDK is downloaded internally by the pulumi-package-publisher action.
@danielrbradley danielrbradley self-assigned this Dec 12, 2024
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's make sure we test it before merging.

@danielrbradley
Copy link
Member Author

danielrbradley commented Dec 12, 2024

Pushing to pulumi-random: https://github.com/pulumi/ci-mgmt/actions/runs/12296659267
PR: pulumi/pulumi-random#1450
Main workflow run: https://github.com/pulumi/pulumi-random/actions/runs/12297227804

Failed with: Error: Invalid provider version: 4.17.0a1734009471

@danielrbradley
Copy link
Member Author

danielrbradley commented Dec 12, 2024

Testing fix of using packageVersion instead of providerVersion

Pushing to pulumi-random: https://github.com/pulumi/ci-mgmt/actions/runs/12297668850
PR: pulumi/pulumi-random#1452
Main workflow run: https://github.com/pulumi/pulumi-random/actions/runs/12297836532

Failure:
The restore has completed, but when running pulumi preview it fails with an error about not finding the Pulumi SDK. Possibly a venv error.

@danielrbradley
Copy link
Member Author

This is now fully passing for pulumi-random 🎉

@danielrbradley danielrbradley added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@danielrbradley danielrbradley added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 84bf03d Dec 12, 2024
7 checks passed
@danielrbradley danielrbradley deleted the 1219-fix-python-sdk-verification branch December 12, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass python SDK version into release verification
2 participants