Update example on https://www.pulumi.com/tf2pulumi/

[meagancojocar]

Problem description

The program this generates doesn't run for me: https://www.pulumi.com/tf2pulumi/

[thoward]

First step is to figure out which examples are broken. This page has example programs in TF HCL for Aws, Azure, and GKE, and converts each those to four languages, TypeScript, Python, Go, and C#. So, we need to test all of:

AWS:

• aws-tf -> aws-ts
• aws-tf -> aws-py
• aws-tf -> aws-go
• aws-tf -> aws-csharp

Azure:

• azure-tf -> azure-ts
• azure-tf -> azure-py
• azure-tf -> azure-go
• azure-tf -> azure-csharp

GKE:

• gke-tf -> gke-ts
• gke-tf -> gke-py
• gke-tf -> gke-go
• gke-tf -> gke-csharp

(I'll test and come back and check these off if they are passing).

The seed examples are hardcoded into this file:
https://github.com/pulumi/docs/blob/master/content/migrate/tf2pulumi.md?plain=1

And the service that handles the conversion is located here:
https://github.com/pulumi/home/tree/master/infrastructure/tf2pulumi-service

One immediate issue that jumps out at me is that the service is just shelling out to pulumi convert and uses a fixed version string to select the version of the Pulumi CLI to download and use. This is currently set to 3.95.0 (code ref, last updated about 2 years ago) while the latest release of Pulumi CLI is 3.148.0. I am guessing that we have improved the conversion tool since then.

That said, I would also think that pinning the version of the CLI should ensure that the hardcoded examples will continue to work as expected. I suspect the issue is changes in the underlying providers, which are not pinned, leading to API drift over time.

Last folks who worked on the backend service were @mikhailshilkov and @justinvp.

[thoward]

Note, circling back to this now. Looks like kmosher updated the Pulumi CLI version to 3.150.0 in the tf2pulumi service here: https://github.com/pulumi/home/blob/master/infrastructure/tf2pulumi-service/handlers/convert/main.go#L28 ... will update the code samples now that we are a bit more modernized (although we've already moved past that version number in CLI releases).

[thoward]

I checked through all the examples and update the source Terraform code as needed to make them pass.

This process involved a lot of use of our default templates like azure-typescript and gcp-go, etc. Turns out a lot of our templates are out of date (e.g. have references to old library versions and don't "just work") meaning my testing strategy of creating the directory with the default template for the cloud/language, then replacing with the output of the converter to test, couldn't work that well. Ultimately all tests pass with the changes i filed in the PR.