Skip to content

Commit d54f14b

Browse files
authored
Migrate from @azure/ms-rest-nodeauth to @azure/identity as the former is deprecated and has a CVE (#2225)
Resolves #1440 The NodeJS SDK has some hand-written mixins that haven't been updated in a long time. This PR replaces the deprecated @azure/ms-rest-nodeauth package, that has a CVE open (see #1440), with the current @azure/identity package. The previous PR #2217 restored some test coverage for this change, although not all auth methods are covered. CI uses Service Principal with client secret, and I ran it locally using CLI auth.
1 parent fbc5598 commit d54f14b

File tree

4 files changed

+19
-16
lines changed

4 files changed

+19
-16
lines changed

provider/cmd/pulumi-resource-azure/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,8 @@
168168
"dependencies": {
169169
"@azure/eventgrid": "^4.6.0",
170170
"@azure/functions": "=1.2.2",
171+
"@azure/identity": "^4.0.0",
171172
"@azure/ms-rest-azure-js": "^2.0.1",
172-
"@azure/ms-rest-nodeauth": "^3.0.0",
173173
"@pulumi/pulumi": "^3.0.0",
174174
"azure-functions-ts-essentials": "^1.3.2",
175175
"moment": "2.29.4",

provider/resources.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3160,8 +3160,8 @@ func Provider() tfbridge.ProviderInfo {
31603160
"@pulumi/pulumi": "^3.0.0",
31613161
"@azure/eventgrid": "^4.6.0",
31623162
"@azure/functions": "=1.2.2",
3163+
"@azure/identity": "^4.0.0",
31633164
"@azure/ms-rest-azure-js": "^2.0.1",
3164-
"@azure/ms-rest-nodeauth": "^3.0.0",
31653165
"azure-functions-ts-essentials": "^1.3.2",
31663166
"moment": "2.29.4",
31673167
"node-fetch": "^2.3.0",

sdk/nodejs/core/zMixins.ts

Lines changed: 16 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/nodejs/package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)