From b5b31af50c37e30ee8f23eb074ac62d0cb990e1f Mon Sep 17 00:00:00 2001 From: Kyle Dixler Date: Tue, 11 Jul 2023 12:53:33 -0700 Subject: [PATCH 1/5] Bump NodeJS in base image to NodeJS LTS (v18) --- CHANGELOG.md | 4 ++++ README.md | 6 +++++- docker/pulumi/Dockerfile | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5488c3ea..b4be7a72 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # CHANGELOG +## 3.80.0 + +- Upgrade NodeJS in the Pulumi base image to 18 ([#150](https://github.com/pulumi/pulumi-docker-containers/pull/150)) + ## 3.63.0 - Upgrade Go to 1.20.3. ([#134](https://github.com/pulumi/pulumi-docker-containers/pull/134)) diff --git a/README.md b/README.md index 5a6071e6..0c949b8e 100644 --- a/README.md +++ b/README.md @@ -37,9 +37,13 @@ Images are pushed to: - .NET 6.0 - Go 1.20 - JDK 11 -- Node.js 16 +- Node.js 18 - Python 3.9 +### NodeJS LTS + +Our Docker images aim to use NodeJS LTS version (v18 as of writing). You can pin the image tag to a particular version in order to avoid unintended upgrades. + ## Scanning Images are scanned nightly for vulnerabilities. Results are checked periodically for issues that can be remediated (best effort), however there are some issues over which we have no control, e.g. vulnerabilities in base images for which there is no known remediation. diff --git a/docker/pulumi/Dockerfile b/docker/pulumi/Dockerfile index 61d5f217..0611b097 100644 --- a/docker/pulumi/Dockerfile +++ b/docker/pulumi/Dockerfile @@ -39,7 +39,7 @@ RUN apt-get update -y && \ rm -rf aws && \ rm awscliv2.zip && \ # Add additional apt repos all at once - echo "deb https://deb.nodesource.com/node_16.x $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/node.list && \ + echo "deb https://deb.nodesource.com/node_18.x $(lsb_release -cs) main" | tee /etc/apt/sources.list.d/node.list && \ echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list && \ echo "deb [arch=amd64] https://download.docker.com/linux/debian $(lsb_release -cs) stable" | tee /etc/apt/sources.list.d/docker.list && \ echo "deb http://packages.cloud.google.com/apt cloud-sdk-$(lsb_release -cs) main" | tee /etc/apt/sources.list.d/google-cloud-sdk.list && \ From fa195d688f2dda2ca21b51e548bcae6414a87782 Mon Sep 17 00:00:00 2001 From: Justin Van Patten Date: Fri, 8 Sep 2023 15:59:21 -0700 Subject: [PATCH 2/5] Use `node:18-bullseye-slim` for the `pulumi/nodejs` image Before it was using `lts-bullseye-slim`, which is currently the same as `18-bullseye-slim`. This commit changes it it to `18-bullseye-slim` so that it remains on 18 once the LTS version changes. That way, we can upgrade all images to the next LTS version at the same time, and not have one images that is using a different version that the others. --- docker/nodejs/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/nodejs/Dockerfile b/docker/nodejs/Dockerfile index 25a7ec09..75b5ec4c 100644 --- a/docker/nodejs/Dockerfile +++ b/docker/nodejs/Dockerfile @@ -15,7 +15,7 @@ RUN curl -fsSL https://get.pulumi.com/ | bash -s -- --version $PULUMI_VERSION # The runtime container -FROM node:lts-bullseye-slim +FROM node:18-bullseye-slim LABEL org.opencontainers.image.description="Pulumi CLI container for nodejs" WORKDIR /pulumi/projects From f647b9e27888b55f85fea1d4b485afb11e04152e Mon Sep 17 00:00:00 2001 From: Justin Van Patten Date: Fri, 8 Sep 2023 16:00:07 -0700 Subject: [PATCH 3/5] Upgrade the `pulumi/nodejs` `-ubi` image to use Node 18 --- docker/nodejs/dnf/nodejs.module | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/nodejs/dnf/nodejs.module b/docker/nodejs/dnf/nodejs.module index fe67f378..3f3e2a3c 100644 --- a/docker/nodejs/dnf/nodejs.module +++ b/docker/nodejs/dnf/nodejs.module @@ -1,5 +1,5 @@ [nodejs] name=nodejs -stream=14 +stream=18 profiles= state=enabled From b74f781f71e596e9191f3378fd77851f7a61d21e Mon Sep 17 00:00:00 2001 From: Justin Van Patten Date: Fri, 8 Sep 2023 16:10:23 -0700 Subject: [PATCH 4/5] Update CHANGELOG.md --- CHANGELOG.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b4be7a72..bb1680aa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ # CHANGELOG -## 3.80.0 +## 3.82.0 -- Upgrade NodeJS in the Pulumi base image to 18 ([#150](https://github.com/pulumi/pulumi-docker-containers/pull/150)) +- Upgrade Node.js in the `pulumi/pulumi` image and `pulumi/nodejs` UBI image to the Active LTS version 18 + ([#150](https://github.com/pulumi/pulumi-docker-containers/pull/150)) ## 3.63.0 From 9b7b5182e37d4955ca66f46fc0a23c0917fa69b4 Mon Sep 17 00:00:00 2001 From: Justin Van Patten Date: Fri, 8 Sep 2023 16:10:56 -0700 Subject: [PATCH 5/5] Update README.md with policy Also tweak the cadence as we aim to release weekly now. --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 0c949b8e..48c719a5 100644 --- a/README.md +++ b/README.md @@ -40,9 +40,9 @@ Images are pushed to: - Node.js 18 - Python 3.9 -### NodeJS LTS +### Version Policy -Our Docker images aim to use NodeJS LTS version (v18 as of writing). You can pin the image tag to a particular version in order to avoid unintended upgrades. +Language runtimes are kept up-to-date with current LTS versions. You can pin the image tag to a particular version in order to avoid unintended upgrades. ## Scanning @@ -62,6 +62,6 @@ The base and SDK images _do not_ include additional tools you might want to use ## Release Cadence -The images in this repository are released automatically as part of the release process for the `pulumi` CLI. You can expect **new minor releases** roughly every other week, with patch releases more frequently as necessary. +The images in this repository are released automatically as part of the release process for the `pulumi` CLI. You can expect **new minor releases** roughly every week, with patch releases more frequently as necessary. The image tags for each image in this repository mirror the git tags on the `pulumi` CLI. Thus, when [`pulumi v3.35.1`](https://github.com/pulumi/pulumi/releases) is released, you will find a corresponding Docker image [`pulumi/pulumi:3.35.1`](https://hub.docker.com/r/pulumi/pulumi) in DockerHub, ECR, and GHCR.