Use older rubygems-update on AIX 7.2 #2457
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validate_vendored_ruby test started failing on AIX 7.2 when loading the
gemspecs from artifactory:
# /opt/puppetlabs/puppet/bin/gem update --system -V
GET https://rubygems.org/specs.4.8.gz
304 Not Modified
GET https://artifactory.delivery.puppetlabs.net/artifactory/api/gems/rubygems/specs.4.8.gz
304 Not Modified
[FATAL] failed to allocate memory
It appears the new behavior is triggered when using the new safe marshall code
introduced in rubygems-update[1]:
# truss -f -i -t kopen /opt/puppetlabs/puppet/bin/gem update --system
...
10813880: 11338039: kopen("/root/.local/share/gem/specs/rubygems.org%443/specs.4.8", 0440000002) = 9
10813880: 11338039: kopen("/opt/puppetlabs/puppet/lib/ruby/site_ruby/3.2.0/rubygems/safe_marshal.rb", 0440000004) = 9
...
10813880: 11338039: kopen("/root/.local/share/gem/specs/artifactory.delivery.puppetlabs.net%443/artifactory/api/gems/rubygems/specs.4.8", 0440000004) = 10
[FATAL] failed to allocate memory
Pin back to an older rubygems-update on AIX 7.2.
[1] rubygems/rubygems#6896
|
I manually tested this using: |
|
This doesn't need to be backported because we already pinned this test to use rubygems 3.4.22 in the 7.x branch, see 3ce3b43 |
joshcooper
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validate_vendored_ruby test started failing on AIX 7.2 when loading the
gemspecs from artifactory:
It appears the new behavior is triggered when using the new safe marshall code
introduced in rubygems-update[1]:
Pin back to an older rubygems-update on AIX 7.2.
[1] rubygems/rubygems#6896