Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virt-what #588

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Update virt-what #588

merged 1 commit into from
Apr 16, 2024

Conversation

smokris
Copy link
Contributor

@smokris smokris commented Oct 3, 2022

Puppet currently bundles virt-what 1.22, which incorrectly reports Illumos/SmartOS/OmniOS LX virtualization. This PR updates to the latest version (which fixes that issue).

@smokris smokris requested review from a team as code owners October 3, 2022 18:36
@puppetlabs-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@joshcooper joshcooper added the enhancement New feature or request label Apr 11, 2024
@joshcooper
Copy link
Contributor

Could you rebase and resolve conflicts?

@smokris smokris requested a review from a team as a code owner April 14, 2024 23:45
@smokris
Copy link
Contributor Author

smokris commented Apr 14, 2024

@joshcooper I just pushed a new version rebased on latest master.

Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success! https://artifactory.delivery.puppetlabs.net/artifactory/generic__buildsources/buildsources/virt-what-1.25.tar.gz md5: 2345f1ec5fa0836bff4071659730ac8f sha256: d4fcb423622bafbe5e2bbcd84b7d92ad4d583f4778b225b72c4a81ae9fc3c73d

@joshcooper joshcooper merged commit a479ba6 into puppetlabs:master Apr 16, 2024
3 checks passed
@joshcooper
Copy link
Contributor

Thanks @smokris!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants