Disable nghttp2 explicitly #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthorn42
approved these changes
Apr 22, 2024
After commit 9a62dd5, curl 8 on AIX was adding a runtime dependency on libnghttp2 because the library happened to be present in /opt/freeware/lib: # ldd /opt/puppetlabs/puppet/bin/curl /opt/puppetlabs/puppet/bin/curl needs: /usr/lib/libc.a(shr.o) /usr/lib/libpthreads.a(shr_xpg5.o) /opt/puppetlabs/puppet/lib/libcurl.a(libcurl.so.4) /opt/puppetlabs/puppet/lib/libz.a(libz.so.1) Cannot find libnghttp2.a(libnghttp2.so.14) However, libnghttp2 is not a runtime component nor is it redistributed with the agent, so curl would fail to load: exec(): 0509-036 Cannot load program curl because of the following errors: 0509-150 Dependent module libnghttp2.a(libnghttp2.so.14) could not be loaded. 0509-022 Cannot load module libnghttp2.a(libnghttp2.so.14). 0509-026 System error: A file or directory in the path name does not exist. Since we don't enable nghttp2 on other platforms, explicitly disable it so we're not sensitive to build host differences. Note curl uses enable/disable for optional features like ldap, but with/without for optional packages like nghttp2.
|
I built this on all supported agent main platforms |
joshcooper
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit 9a62dd5, curl 8 on AIX was adding a runtime dependency on libnghttp2 because the library happened to be present in /opt/freeware/lib:
However, libnghttp2 is not a runtime component nor is it redistributed with the agent, so curl would fail to load:
Since we don't enable nghttp2 on other platforms, explicitly disable it so we're not sensitive to build host differences.
Note curl uses enable/disable for optional features like ldap, but with/without for optional packages like nghttp2.