Disable reports by default

The default value for this goes all the way back to when it was
introduced in 566bf78. I'd argue it a
bad default, because it just writes files without any clean up process
in place. That only causes hard disks to fill up.

Having reports should be an opt in feature, where they make a careful
choice. PuppetDB is an obvious recommended option but not one that can
be relied on by default.

Author: ekohl

lib/puppet/defaults.rb

@@ -1477,7 +1477,7 @@ def self.initialize_default_settings!(settings)
       :mode => "0750",
       :desc => "The directory in which serialized data is stored, usually in a subdirectory."},
     :reports => {
-      :default    => "store",
+      :default    => "none",
       :desc       => "The list of report handlers to use. When using multiple report handlers,
         their names should be comma-separated, with whitespace allowed. (For example,
         `reports = http, store`.)

lib/puppet/reference/report.rb

@@ -21,5 +21,6 @@
 
 none
 ----
-Discard all reports received.
+Discard all reports received. This is the default handler when the `reports`
+setting is unset.
 "

lib/puppet/reports/store.rb

@@ -11,8 +11,7 @@
     and this just stores the file on disk, in the `reportdir` directory.
 
     These files collect quickly -- one every half hour -- so it is a good idea
-    to perform some maintenance on them if you use this report (it's the only
-    default report)."
+    to perform some maintenance on them if you use this report."
 
   def process
     validate_host(host)