From fce3ad2107bd6e110b1d36b9cc544729cf42e9f5 Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Fri, 30 Aug 2024 19:10:37 +0200 Subject: [PATCH 1/2] Document the none report handler --- lib/puppet/reference/report.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/puppet/reference/report.rb b/lib/puppet/reference/report.rb index c678ab1a05b..0b7d526cda0 100644 --- a/lib/puppet/reference/report.rb +++ b/lib/puppet/reference/report.rb @@ -19,4 +19,7 @@ See [About Reporting](https://puppet.com/docs/puppet/latest/reporting_about.html) for more details. +none +---- +Discard all reports received. " From 148e599b2b0d933ff5db37d3eaa2cb996a454d4d Mon Sep 17 00:00:00 2001 From: Ewoud Kohl van Wijngaarden Date: Wed, 28 Aug 2024 22:50:55 +0200 Subject: [PATCH 2/2] Disable reports by default The default value for this goes all the way back to when it was introduced in 566bf7820e56b3be503a05645cad54152309b20f. I'd argue it a bad default, because it just writes files without any clean up process in place. That only causes hard disks to fill up. Having reports should be an opt in feature, where they make a careful choice. PuppetDB is an obvious recommended option but not one that can be relied on by default. --- lib/puppet/defaults.rb | 2 +- lib/puppet/reference/report.rb | 3 ++- lib/puppet/reports/store.rb | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/puppet/defaults.rb b/lib/puppet/defaults.rb index 7d41b7749e9..fd32a3e480c 100644 --- a/lib/puppet/defaults.rb +++ b/lib/puppet/defaults.rb @@ -1477,7 +1477,7 @@ def self.initialize_default_settings!(settings) :mode => "0750", :desc => "The directory in which serialized data is stored, usually in a subdirectory."}, :reports => { - :default => "store", + :default => "none", :desc => "The list of report handlers to use. When using multiple report handlers, their names should be comma-separated, with whitespace allowed. (For example, `reports = http, store`.) diff --git a/lib/puppet/reference/report.rb b/lib/puppet/reference/report.rb index 0b7d526cda0..57ecefb4b60 100644 --- a/lib/puppet/reference/report.rb +++ b/lib/puppet/reference/report.rb @@ -21,5 +21,6 @@ none ---- -Discard all reports received. +Discard all reports received. This is the default handler when the `reports` +setting is unset. " diff --git a/lib/puppet/reports/store.rb b/lib/puppet/reports/store.rb index 370e92d622c..0283b76f43f 100644 --- a/lib/puppet/reports/store.rb +++ b/lib/puppet/reports/store.rb @@ -11,8 +11,7 @@ and this just stores the file on disk, in the `reportdir` directory. These files collect quickly -- one every half hour -- so it is a good idea - to perform some maintenance on them if you use this report (it's the only - default report)." + to perform some maintenance on them if you use this report." def process validate_host(host)