Skip to content

extension_request and custom_attribute should be pluralised #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jessereynolds opened this issue Apr 11, 2019 · 0 comments
Open

extension_request and custom_attribute should be pluralised #81

jessereynolds opened this issue Apr 11, 2019 · 0 comments

Comments

@jessereynolds
Copy link

It was surprising to me that the parameter for specifying multiple certificate extension requests via an array was the singular extension_request, and similarly for custom_attribute. We talk about "extension requests" in the docs, we have parameters in the install.ps1 and install.bash scripts named extension_requests and custom_attributes, so it makes sense to be consistent.

Recommendation: rename these parameters to extension_requests and custom_attributes. Possibly add aliases of these for the singular versions for backwards compatibility, although the module is not yet at 1.0 so this isn't strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant