You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It was surprising to me that the parameter for specifying multiple certificate extension requests via an array was the singular extension_request, and similarly for custom_attribute. We talk about "extension requests" in the docs, we have parameters in the install.ps1 and install.bash scripts named extension_requests and custom_attributes, so it makes sense to be consistent.
Recommendation: rename these parameters to extension_requests and custom_attributes. Possibly add aliases of these for the singular versions for backwards compatibility, although the module is not yet at 1.0 so this isn't strictly necessary.
The text was updated successfully, but these errors were encountered:
It was surprising to me that the parameter for specifying multiple certificate extension requests via an array was the singular
extension_request
, and similarly forcustom_attribute
. We talk about "extension requests" in the docs, we have parameters in the install.ps1 and install.bash scripts namedextension_requests
andcustom_attributes
, so it makes sense to be consistent.Recommendation: rename these parameters to
extension_requests
andcustom_attributes
. Possibly add aliases of these for the singular versions for backwards compatibility, although the module is not yet at 1.0 so this isn't strictly necessary.The text was updated successfully, but these errors were encountered: