(MODULES-11188) Fix physicalPath on apps and sites

Prior to this commit it looks like we'd chosen the incorrect property
to pull back from the iis config. PhysicalPath != physicalPath and the
former was behaving differently between the app and site resources.

This commit standardises on physicalPath which returns the correct value
for both app and site resources. For clarity, physicalPath returns a
string which we can directly manipulate if required.

Author: chelnak

lib/puppet/provider/templates/webadministration/_getwebsites.ps1.erb

@@ -8,10 +8,10 @@ Get-WebSite | % {
   }
 
   $SiteEntityPath = "IIS:\\Sites\${name}"
-  $SitePhysicalPath = Get-ItemProperty -Path $SiteEntityPath -Name PhysicalPath
+  $SiteEntityPhysicalPath = Get-ItemProperty -Path $SiteEntityPath -Name physicalPath
 
-  if ($SitePhysicalPath.physicalpath.EndsWith('/')){
-    $null = Set-ItemProperty -Path $SiteEntityPath -Name PhysicalPath -Value $SitePhysicalPath.physicalpath.TrimEnd('/') -Force
+  if ($SiteEntityPhysicalPath.EndsWith('/')){
+    $null = Set-ItemProperty -Path $SiteEntityPath -Name PhysicalPath -Value $SiteEntityPhysicalPath.TrimEnd('/') -Force
   }
 
   $authenticationTypes = @(

lib/puppet/provider/templates/webadministration/getapps.ps1.erb

@@ -4,11 +4,11 @@ Get-WebApplication | % {
   $name = [string]$pattern.replace($_.Path,'',1)
   $site = [string]$_.ItemXPath.split("'")[1]
 
-  $SiteEntityPath = "IIS:\\Sites\${site}"
-  $SitePhysicalPath = Get-ItemProperty -Path $SiteEntityPath -Name PhysicalPath
+  $AppEntityPath = "IIS:\\Sites\${site}\${name}"
+  $AppEntityPhysicalPath = Get-ItemProperty -Path $AppEntityPath -Name physicalPath
 
-  if ($SitePhysicalPath.physicalpath.EndsWith('/')){
-    $null = Set-ItemProperty -Path $SiteEntityPath -Name PhysicalPath -Value $SitePhysicalPath.physicalpath.TrimEnd('/') -Force
+  if ($AppEntityPhysicalPath.EndsWith('/')){
+    $null = Set-ItemProperty -Path $AppEntityPath -Name physicalPath -Value $AppEntityPhysicalPath.TrimEnd('/') -Force
   }
 
   $sslFlags = @()