adjust suse connect, remove docker provisioning

Author: LukasAud

Gemfile

@@ -64,7 +64,8 @@ group :development, :release_prep do
   gem "puppet-blacksmith", '~> 7.0',      require: false
 end
 group :system_tests do
-  gem "puppet_litmus", git: 'https://github.com/puppetlabs/puppet_litmus', branch: 'CAT-2476-Address_SLES_failures', require: false, platforms: [:ruby, :x64_mingw]
+  gem "puppet_litmus", '~> 2.4',   require: false, platforms: [:ruby, :x64_mingw] if !ENV['PUPPET_FORGE_TOKEN'].to_s.empty?
+  gem "puppet_litmus", '~> 1.0',   require: false, platforms: [:ruby, :x64_mingw] if ENV['PUPPET_FORGE_TOKEN'].to_s.empty?
   gem "CFPropertyList", '< 3.0.7', require: false, platforms: [:mswin, :mingw, :x64_mingw]
   gem "serverspec", '~> 2.41',     require: false
 end

manifests/init.pp

@@ -111,11 +111,12 @@
   }
 
   # If the OS is SLES >= 15.3, enable the legacy repo to install net-tools-deprecated package
+  # Only attempt this if the system is registered with SUSE
   if ($facts['os']['family'] in ['SLES', 'SUSE']) and (versioncmp($facts['os']['release']['full'], '15.3') >= 0) {
     exec { 'Enable legacy repos':
       path    => '/bin:/usr/bin/:/sbin:/usr/sbin',
-      command => "SUSEConnect --product sle-module-legacy/${facts['os']['release']['full']}/x86_64",
-      unless  => "SUSEConnect --status-text | grep sle-module-legacy/${facts['os']['release']['full']}/x86_64",
+      command => "SUSEConnect --product sle-module-legacy/${facts['os']['release']['major']}/x86_64",
+      unless  => "test ! -f /usr/bin/SUSEConnect || SUSEConnect --status-text | grep -q 'Not Registered' || SUSEConnect --status-text | grep sle-module-legacy/${facts['os']['release']['major']}/x86_64",
     }
   }