Merge pull request #1522 from JvGinkel/fix_undef_touch

xtrabackup.sh only touch when backup_success_file_path is set

Author: LukasAud

spec/classes/mysql_backup_xtrabackup_spec.rb

@@ -25,6 +25,12 @@ class { 'mysql::server': }
           default_params
         end
 
+        it 'does not contain the touch command' do
+          is_expected.to contain_file('xtrabackup.sh').without_content(
+            %r{(^\s+touch\s+$)},
+          )
+        end
+
         it 'contains the wrapper script' do
           is_expected.to contain_file('xtrabackup.sh').with_content(
             %r{(\n*^xtrabackup\s+.*\$@)},
@@ -304,6 +310,18 @@ class { 'mysql::server': }
           )
         end
       end
+
+      context 'with backup_success_file_path' do
+        let(:params) do
+          { backup_success_file_path: '/tmp/backup_success' }.merge(default_params)
+        end
+
+        it 'contain the touch /tmp/backup_success command' do
+          is_expected.to contain_file('xtrabackup.sh').with_content(
+            %r{(^\s+touch /tmp/backup_success$)},
+          )
+        end
+      end
     end
   end
   # rubocop:enable RSpec/NestedGroups

templates/xtrabackup.sh.erb

@@ -59,7 +59,9 @@ cleanup
 <% unless @delete_before_dump -%>
 if [ $? -eq 0 ] ; then
     cleanup
+    <% if @backup_success_file_path -%>
     touch <%= @backup_success_file_path %>
+    <% end -%>
 fi
 <% end -%>