expand postgresql_conf type and provider

Author: SimonHoenscheid

lib/puppet/provider/postgresql_conf/parsed.rb

@@ -14,7 +14,7 @@
   text_line :blank, match: %r{^\s*$}
 
   record_line :parsed,
-              fields: ['name', 'value', 'comment'],
+              fields: ['key', 'value', 'comment'],
               optional: ['comment'],
               match: %r{^\s*([\w.]+)\s*=?\s*(.*?)(?:\s*#\s*(.*))?\s*$},
               to_line: proc { |h|
@@ -28,9 +28,9 @@
                         h[:value]
                       end
                 dontneedquote = val.match(%r{^(\d+.?\d+|\w+)$})
-                dontneedequal = h[:name].match(%r{^(include|include_if_exists)$}i)
+                dontneedequal = h[:key].match(%r{^(include|include_if_exists)$}i)
 
-                str =  h[:name].downcase # normalize case
+                str =  h[:key].downcase # normalize case
                 str += dontneedequal ? ' ' : ' = '
                 str += "'" unless dontneedquote && !dontneedequal
                 str += val
@@ -39,7 +39,7 @@
                 str
               },
               post_parse: proc { |h|
-                h[:name].downcase! # normalize case
+                h[:key].downcase! # normalize case
                 h[:value].gsub!(%r{(^'|'$)}, '') # strip out quotes
               }
 end

lib/puppet/type/postgresql_conf.rb

@@ -6,12 +6,16 @@
   ensurable
 
   newparam(:name) do
-    desc 'The postgresql parameter name to manage.'
-    isnamevar
+    desc 'A unique title for the resource.'
 
     newvalues(%r{^[\w.]+$})
   end
 
+  newproperty(:key) do
+    desc 'The Postgresql parameter to manage.'
+    newvalues(%r{^[\w.]+$})
+  end
+
   newproperty(:value) do
     desc 'The value to set for this parameter.'
   end

manifests/server/config_entry.pp

@@ -85,7 +85,7 @@
   postgresql_conf { $name:
     ensure  => $ensure,
     target  => $path,
-    name    => $key,
+    key     => $key,
     value   => $value,
     require => Class['postgresql::server::initdb'],
   }