PE-40175

Prior to this commit the sshkey type didn't prohibit whitespace in the
key property. This change now fails the resource type if a user adds
space and adds a spec test

Author: taikaa

lib/puppet/type/sshkey.rb

@@ -52,7 +52,7 @@ def self.title_patterns
     end
 
     newproperty(:key) do
-      desc "The key itself; generally a long string of uuencoded characters. The `key`
+      desc "The key itself; generally a long string of unencoded characters. The `key`
         attribute may not contain whitespace.
 
         Make sure to omit the following in this attribute (and specify them in
@@ -61,6 +61,9 @@ def self.title_patterns
         * Key headers, such as 'ssh-rsa' --- put these in the `type` attribute.
         * Key identifiers / comments, such as 'joescomputer.local' --- put these in
           the `name` attribute/resource title."
+      validate do |value|
+        raise Puppet::Error, _('Key must not contain whitespace: %{value}') % { value: value } if %r{\s}.match?(value)
+      end
     end
 
     # FIXME: This should automagically check for aliases to the hosts, just

spec/unit/type/sshkey_spec.rb

@@ -76,6 +76,12 @@
       }.to raise_error(Puppet::Error, %r{cannot include whitespace})
     end
 
+    it "doesn't accept whitespace in the key contents" do
+      expect {
+        described_class.new(name: 'foo', key: 'AAA FA==')
+      }.to raise_error(Puppet::Error, %r{Key must not contain whitespace})
+    end
+
     it "doesn't accept aliases in the resourcename" do
       expect {
         described_class.new(name: 'host,host.domain,ip')