Skip to content

Commit d3707a3

Browse files
authored
Merge pull request #8 from srghma/master
feat: update to purescript v0.13.6, to halogen-vdom v6.1.2
2 parents 2277c7f + 09fafb8 commit d3707a3

File tree

4 files changed

+28
-29
lines changed

4 files changed

+28
-29
lines changed

bower.json

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212
"output"
1313
],
1414
"dependencies": {
15-
"purescript-prelude": "^3.0.0",
16-
"purescript-halogen-vdom": "^2.0.0"
15+
"purescript-prelude": "^4.1.1",
16+
"purescript-halogen-vdom": "^6.1.0",
17+
"purescript-ordered-collections": "^1.6.1",
18+
"purescript-foreign": "^5.0.0"
1719
}
1820
}

package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@
55
"build": "pulp build -- --censor-lib --strict"
66
},
77
"devDependencies": {
8-
"pulp": "^11.0.0",
9-
"purescript-psa": "^0.5.1",
10-
"purescript": "^0.11.4",
11-
"rimraf": "^2.6.1"
8+
"pulp": "^14.0.0",
9+
"purescript-psa": "^0.7.3",
10+
"purescript": "^0.13.6",
11+
"rimraf": "^3.0.2"
1212
}
1313
}

src/Halogen/VDom/DOM/StringRenderer.purs

+6-9
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ import Prelude
44
import Halogen.VDom (VDom, ElemName(..))
55
import Halogen.VDom.DOM.Prop (Prop(..), PropValue)
66
import Data.Array as A
7-
import Data.Foreign (toForeign, typeOf)
7+
import Foreign (unsafeToForeign, typeOf)
88
import Data.Maybe (Maybe(..))
99
import Data.String as S
10-
import Data.StrMap as SM
11-
import Data.Tuple (Tuple(..))
10+
import Data.Set as Set
1211
import Halogen.VDom.StringRenderer as VSR
1312
import Halogen.VDom.StringRenderer.Util (escape)
1413
import Unsafe.Coerce (unsafeCoerce)
@@ -18,7 +17,7 @@ render renderWidget = VSR.render getTagType renderProps renderWidget
1817

1918
getTagType ElemName VSR.TagType
2019
getTagType (ElemName en)
21-
| SM.member en voidElements = VSR.SelfClosingTag
20+
| Set.member en voidElements = VSR.SelfClosingTag
2221
| otherwise = VSR.NormalTag
2322

2423
renderProps i. Array (Prop i) String
@@ -41,19 +40,17 @@ propNameToAttrName = case _ of
4140
p → p
4241

4342
renderProperty String PropValue Maybe String
44-
renderProperty name prop = case typeOf (toForeign prop) of
43+
renderProperty name prop = case typeOf (unsafeToForeign prop) of
4544
"string" → renderAttr name' $ (unsafeCoerce PropValue String) prop
4645
"number" → renderAttr name' $ show ((unsafeCoerce PropValue String) prop)
4746
"boolean"Just $ escape name'
4847
_ → Nothing
4948
where
5049
name' = propNameToAttrName name
5150

52-
voidElements :: SM.StrMap Unit
51+
voidElements :: Set.Set String
5352
voidElements =
54-
SM.fromFoldable
55-
$ map (flip Tuple unit)
56-
$ names
53+
Set.fromFoldable names
5754
where
5855
names =
5956
[ "area"

src/Halogen/VDom/StringRenderer.purs

+14-14
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ module Halogen.VDom.StringRenderer
66
import Prelude
77

88
import Data.Array as A
9-
import Data.Maybe (maybe)
9+
import Data.Maybe (Maybe, maybe)
1010
import Data.String as S
1111
import Data.Tuple (snd)
1212

13-
import Halogen.VDom (VDom(..), ElemSpec(..), ElemName(..), Namespace(..), runGraft)
13+
import Halogen.VDom (VDom(..), ElemName(..), Namespace(..), runGraft)
1414
import Halogen.VDom.StringRenderer.Util (escape)
1515

1616
-- | Type used to determine whether an element can be rendered as self-closing
@@ -25,29 +25,29 @@ derive instance ordTagType ∷ Ord TagType
2525
-- | Renders a `VDom` tree to a string using the specified tag type scheme,
2626
-- | attribute renderer, and widget renderer.
2727
render
28-
a w
28+
attrs widget
2929
. (ElemName TagType)
30-
(a String)
31-
(w String)
32-
VDom a w
30+
(attrs String)
31+
(widget String)
32+
VDom attrs widget
3333
String
3434
render getTagType renderAttrs renderWidget = go
3535
where
36-
go VDom a w String
36+
go VDom attrs widget String
3737
go = case _ of
3838
Text s → escape s
39-
Elem elem children → renderElement elem children
40-
Keyed elem kchildren → renderElement elem (map snd kchildren)
41-
Widget w → renderWidget w
39+
Elem namespace elementName attrs children → renderElement namespace elementName attrs children
40+
Keyed namespace elementName attrs kchildren → renderElement namespace elementName attrs (map snd kchildren)
41+
Widget widget → renderWidget widget
4242
Grafted g → go (runGraft g)
4343

44-
renderElement ElemSpec a Array (VDom a w) String
45-
renderElement (ElemSpec mns en@(ElemName name) attrs) children =
44+
renderElement (Maybe Namespace) -> ElemName -> attrs Array (VDom attrs widget) String
45+
renderElement maybeNamespace elemName@(ElemName name) attrs children =
4646
let
4747
as = renderAttrs attrs
48-
as' = maybe as (\(Namespace ns) -> "xmlns=\"" <> escape ns <> "\"" <> if S.null as then "" else " " <> as) mns
48+
as' = maybe as (\(Namespace ns) -> "xmlns=\"" <> escape ns <> "\"" <> if S.null as then "" else " " <> as) maybeNamespace
4949
in
5050
"<" <> name <> (if S.null as then "" else " ") <> as <>
5151
if A.null children
52-
then if getTagType en == SelfClosingTag then "/>" else "></" <> name <> ">"
52+
then if getTagType elemName == SelfClosingTag then "/>" else "></" <> name <> ">"
5353
else ">" <> S.joinWith "" (map go children) <> "</" <> name <> ">"

0 commit comments

Comments
 (0)