Skip to content

chainId-fix-solution2nd #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025
Merged

chainId-fix-solution2nd #23

merged 4 commits into from
Jun 23, 2025

Conversation

zaryab2000
Copy link
Collaborator

@zaryab2000 zaryab2000 commented Jun 23, 2025

changes:

  1. UniversalAccount -> UniversalAccountId
  2. UniversalAccountId includes chainId too
  3. UniversalAccountId.chain -> UniversalAccountId.chainNamespace
  4. UEAFactory: UEADeployed event emits sourceChainID
  5. relevant fixes in tests.

@zaryab2000 zaryab2000 requested review from Copilot and 0xNilesh June 23, 2025 12:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the codebase by renaming UniversalAccount to UniversalAccountId, adding a chainId field, and renaming the chain field to chainNamespace. It also updates all related tests and events (with UEAFactory now emitting sourceChainId) to reflect the new composite account identifier structure.

Reviewed Changes

Copilot reviewed 10 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/UEA_SVM.t.sol Updated to use UniversalAccountId with lower-case chainNamespace
test/UEA_EVM.t.sol Updated to use UniversalAccountId with explicit chainId values
test/UEAFactory.t.sol Adjusted tests for account deployment, salt generation, and retrieval using UniversalAccountId
src/libraries/Types.sol Updated the struct to UniversalAccountId with new fields
src/UEAFactoryV1.sol Updated all function signatures and event emission to reflect UniversalAccountId changes
src/UEA/UEA_SVM.sol Updated references from UniversalAccount to UniversalAccountId
src/UEA/UEA_EVM.sol Updated references from UniversalAccount to UniversalAccountId
src/Interfaces/IUEAFactory.sol Updated interface function signatures and events accordingly
src/Interfaces/IUEA.sol Updated interface function signatures and parameter descriptions
README.md Updated documentation to reflect the new UniversalAccountId syntax

Copy link
Member

@0xNilesh 0xNilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zaryab2000 zaryab2000 merged commit cf52bf0 into main Jun 23, 2025
@zaryab2000 zaryab2000 deleted the chainId-fix-sol2nd branch June 23, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants