Skip to content

Refactor Mat Dialogs #1825

Description

@schiltpuzzle

Description

We have multiple problems with the current implementation of the Material modals:

problem

  1. In Angular Material’s current implementation of MatDialog, you must manually specify type parameters even though the dialog component already carries its own type definitions.
  2. Some modals are not returning the values that the user has entered, instead they are updating the state themselves.

solution

  1. We should use the library striclyTypedMatDialogs to make out mat dialogs all strictly typed.

  2. The modals should only display inputs or data and taking user input and return them to the parent component. The parent component should handle the updating of the data.

Acceptance Criteria

  • Every dialog should have been upgraded with the new strictlyTypedDialogs library.
  • Every dialog shouldn't update data on their own, instead only taking user inputs and returning them to the parent component.
  • All tests should pass

Additional Information

In the tool PCTS, we are already doing the dialogs this way. That means you can check the PCTS out to find out how it is done.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions