Skip to content

Commit 13744ca

Browse files
authored
Test pvsystem.singlediode against precisely generated IV curves (#1573)
* start to adding tests from data in ivcurves repo * correcting Vth calculation * making current increasing for numpy linear interp * singlediode ivcurve_pnts does not give negative voltage with brentq and newton * adding test for singlediode log spacing methods * adding assertions for i_x and i_xx * adding i_x, i_xx iv curve data * updating whatsnew * reverting changes to pvsystem.singlediode * move precise iv curve fixtures into test_singlediode * updating precise iv curve json to match new schema * testing v_from_i, i_from_v * small refactor * small refactor and update whatsnew * changing Boltzmann's constant * add more to precise iv curve docstring * use SciPy constants * restore whatsnew 0.9.4 * relax i_xx error tolerance * trying lower i_xx atol * update generated iv curves after finding bug in their calcuation * increasing i_xx atol, and adding comment about atol on mac, windows * update whatsnew * update whatsnew and add references to test docs
1 parent bbc863d commit 13744ca

File tree

6 files changed

+20714
-0
lines changed

6 files changed

+20714
-0
lines changed

docs/sphinx/source/whatsnew/v0.9.5.rst

+5
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ Testing
5454
* Added Python 3.11 to test suite. (:pull:`1582`)
5555
* Updated PSM3 test data files to match the new version 3.2.2 data returned
5656
by the PSM3 API (:issue:`1591`, :pull:`1652`)
57+
* Testing :py:func:`pvlib.pvsystem.singlediode`, :py:func:`pvlib.pvsystem.v_from_i`,
58+
and :py:func:`pvlib.pvsystem.i_from_v` against precisely generated IV curve data.
59+
(:issue:`411`, :pull:`1573`)
5760

5861

5962
Documentation
@@ -81,3 +84,5 @@ Contributors
8184
* Michael Deceglie (:ghuser:`mdeceglie`)
8285
* Saurabh Aneja (:ghuser:`spaneja`)
8386
* John Moseley (:ghuser:`johnMoseleyArray`)
87+
* Mark Campanelli (:ghuser:`markcampanelli`)
88+
* Taos Transue (:ghuser:`reepoi`)

0 commit comments

Comments
 (0)